show transformed data not dataop itself in fit report#1623
Merged
Conversation
11 tasks
rcap107
pushed a commit
to rcap107/skrub
that referenced
this pull request
Sep 25, 2025
rcap107
pushed a commit
that referenced
this pull request
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
learner.report(env, mode="fit")currently shows for each node the dataop itself, rather than the intermediate result (eg as fit_transform would)for example
For the first report ("fit") in the main branch the (wrong) displayed output is the display of the intermediate data op itself:
In the fixed report it is the actual output of this step:
(note the output of the final supervised estimator in "fit" mode is the estimator itself -- but not the dataop)