rename splitter -> split_func in DataOp.skb.train_test_split#1630
Merged
Conversation
rcap107
pushed a commit
to rcap107/skrub
that referenced
this pull request
Sep 25, 2025
rcap107
pushed a commit
that referenced
this pull request
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"splitter" makes it sound like it expects a cv splitter , but what is expected here is a function with the same signature as scikit-learn's
train_test_splitIt might get even more confusing if we later add a method to iterate over the splits obtained from an actual splitter (as opposed to a single split)
the suggestion here is to rename the parameter to
split_funcand deprecatesplitter