Skip to content

Feat: Add title to report#1654

Merged
rcap107 merged 11 commits into
skrub-data:mainfrom
MarieSacksick:add_title_to_report
Oct 28, 2025
Merged

Feat: Add title to report#1654
rcap107 merged 11 commits into
skrub-data:mainfrom
MarieSacksick:add_title_to_report

Conversation

@MarieSacksick

Copy link
Copy Markdown
Contributor

Closes #1649

@MarieSacksick MarieSacksick changed the title Add title to report Feat: Add title to report Oct 2, 2025
@MarieSacksick

Copy link
Copy Markdown
Contributor Author

blocked by #1656

@MarieSacksick MarieSacksick marked this pull request as ready for review October 7, 2025 09:28
@MarieSacksick MarieSacksick deleted the add_title_to_report branch October 14, 2025 16:51
@MarieSacksick MarieSacksick restored the add_title_to_report branch October 21, 2025 10:00
@MarieSacksick MarieSacksick reopened this Oct 21, 2025
@rcap107

rcap107 commented Oct 27, 2025

Copy link
Copy Markdown
Member

Thanks a lot for the PR @MarieSacksick

Could you please add a small note about this in doc/modules/data_ops/ml_pipeline/evaluating_debugging_data_ops.rst? Something like "it is also possible to give a title to the evaluation report like this..." with a code block? Without using doctests there.

Also, this should have an entry in the changelog.

After that's done, I think we can merge the PR.

@MarieSacksick MarieSacksick marked this pull request as draft October 28, 2025 08:47
@MarieSacksick MarieSacksick marked this pull request as ready for review October 28, 2025 11:12
Comment thread doc/modules/data_ops/ml_pipeline/evaluating_debugging_data_ops.rst Outdated
Comment thread doc/modules/data_ops/ml_pipeline/evaluating_debugging_data_ops.rst Outdated
@rcap107

rcap107 commented Oct 28, 2025

Copy link
Copy Markdown
Member

Looks good to me, thanks a lot @MarieSacksick !

@rcap107 rcap107 merged commit 6ecf8d0 into skrub-data:main Oct 28, 2025
29 checks passed
@MarieSacksick MarieSacksick deleted the add_title_to_report branch December 29, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a title for the Data Ops full report

2 participants