FIX - Fixing a condition in conftest for polars w/out pyarrow#1659
Merged
Conversation
MarieSacksick
approved these changes
Oct 7, 2025
MarieSacksick
left a comment
MarieSacksick
left a comment
Contributor
There was a problem hiding this comment.
oupsy, you're correct.
Member
Author
Happens! Not a big deal |
Contributor
|
Once you merge with main, there is an additional place where you'll have to change the variable name due to an addition, here: https://github.com/skrub-data/skrub/pull/1656/files#diff-9278359efc8c91f314bcf3ae2a7b867c67d653bb233ce367995dd874a1c3db15R112. |
jeromedockes
approved these changes
Oct 9, 2025
Member
|
thanks @rcap107 and @MarieSacksick :) |
Merged
dierickxsimon
pushed a commit
to dierickxsimon/skrub
that referenced
this pull request
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1648 added a slight mistake in how the mark is checked. This PR fixes that and renames the marker so the name is more explicit.