Skip to content

Dataop report titles #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeromedockes merged 4 commits into from
Mar 10, 2026
Merged

Dataop report titles #1950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1fe6fec
_
jeromedockes Mar 5, 2026
a4d3ddf
Merge remote-tracking branch 'upstream/main' into dataop_report_titles
jeromedockes Mar 9, 2026
2f9bcf2
_
jeromedockes Mar 9, 2026
d60e580
_
jeromedockes Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion skrub/_data_ops/_inspection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def make_url(node):
svg = draw_data_op_graph(data_op, url=make_url).svg.decode("utf-8")
jinja_env = _get_jinja_env()
index = jinja_env.get_template("index.html").render(
{"svg": svg, "node_status": node_status, "title": title}
{"svg": svg, "node_status": node_status, "report_title": title}
)
index_file = output_dir / "index.html"
index_file.write_text(index, "utf-8")
Expand Down Expand Up @@ -222,6 +222,7 @@ def make_url(node):
estimator_html_repr = None
node_page = jinja_env.get_template("node.html").render(
dict(
report_title=title,
total_n_nodes=len(g["nodes"]),
node_nb=i,
node_children=node_children,
Expand Down
19 changes: 18 additions & 1 deletion skrub/_reporting/_data/templates/data_ops/data_ops.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ pre, code {
flex-shrink: 0;
}

.fixed-report-title ~ .data_op-node-wrapper > .data_op-node > nav.main-nav {
padding-top: 30px;
}

.node-details {
flex-grow: 1;
flex-shrink: 1;
Expand Down Expand Up @@ -98,12 +102,25 @@ pre, code {
.icon-button {
position: absolute;
left: 5px;
top: 5px;
top: 10px;
padding: 2px;
width: 24px;
height: 24px;
}

.fixed-report-title {
position: absolute;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
max-width: 90%;
left: 40px;
top: 5px;
padding: 2px;
padding-top: 0;
margin: 0;
}

.error-node polygon {
stroke: red;
stroke-width: 3;
Expand Down
6 changes: 3 additions & 3 deletions skrub/_reporting/_data/templates/data_ops/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1">
<title>run report</title>
<title>{{ report_title if report_title else "DataOp report" }}</title>
<style>
{% include "data_ops.css" %}
</style>
</head>

<body>
{% if title %}
<h1>{{ title }}</h1>
{% if report_title %}
<h1>{{ report_title }}</h1>
{% endif %}
<p>
Click on a node to display more information.
Expand Down
11 changes: 7 additions & 4 deletions skrub/_reporting/_data/templates/data_ops/node.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1">
<title>evaluation report</title>
<title>{{ report_title if report_title else "DataOp report" }}</title>
<style>
{% include "data_ops.css" %}
</style>
Expand All @@ -13,6 +13,9 @@
<body>
<button type="button" class="icon-button"
id="toggle-nav">{% include "icons/list.svg" %}</button>
{% if report_title %}
<h2 class="fixed-report-title">{{ report_title }}</h2>
{% endif %}
<div class="data_op-node-wrapper">
<div class="data_op-node">
<nav class="main-nav" data-is-open>
Expand All @@ -21,9 +24,6 @@
<div class="node-details" {{ "data-has-error" if error is not none }}
{{ "data-is-skipped" if (error is none) and (report is none) }}>
<h1>{{ node_nb }}: {{ node_repr }}</h1>
{% if node_name %}
<h2><samp>Name: {{ node_name }}</samp></h2>
{% endif %}
<nav class="mini-nav">
<ul>
<li>
Expand All @@ -41,6 +41,9 @@ <h2><samp>Name: {{ node_name }}</samp></h2>
</li>
</ul>
</nav>
{% if node_name %}
<h2><samp>Name: {{ node_name }}</samp></h2>
{% endif %}
<div>
{% if node_description %}
<h3>Description:</h3>
Expand Down