fix loading cache nullability #50
Merged
+25
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caffeine permits a loader to return null, however the recent alignment to JSpecify annotations applied the NonNull to the loader lambda return type making it impossible to provide a loader that returns null. This attempts to fix the nullability by enforcing `& Any` only where it's required to match the JSpecify annotations. One issue encountered was with bulk loaders, if the bulk mapping function returns a map that doesn't contain the requested key, the cache _will_ return `null` on a single `get(K)`. As such, I've ensured that `asBulkLoadingCache` returns a `LoadingCache<K, V?>`
sksamuel
approved these changes
Aug 28, 2025
Owner
|
awesome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caffeine permits a loader to return null, however the recent alignment to JSpecify annotations applied the NonNull to the loader lambda return type making it impossible to provide a loader that returns null.
This attempts to fix the nullability by enforcing
& Anyonly where it's required to match the JSpecify annotations.One issue encountered was with bulk loaders, if the bulk mapping function returns a map that doesn't contain the requested key, the cache will return
nullon a singleget(K). As such, I've ensured thatasBulkLoadingCachereturns aLoadingCache<K, V?>