[ENH] Add Moirai-MoE foundation model to v2 interface#2329
Conversation
Added Moirai and MoiraiMoE models to the v2 interface of pytorch-forecasting, treating uni2ts as a soft dependency by passing the module directly or loading it internally.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2329 +/- ##
=======================================
Coverage ? 86.77%
=======================================
Files ? 172
Lines ? 9861
Branches ? 0
=======================================
Hits ? 8557
Misses ? 1304
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
hi @phoeenniixx this pr passes all the test pls let me know if this pr needs any changes or if it is good to merge |
| """ | ||
| if self.module is not None: | ||
| return self.module(x) | ||
| raise NotImplementedError("Underlying module is not provided.") |
There was a problem hiding this comment.
Please atleast implement something
phoeenniixx
left a comment
There was a problem hiding this comment.
Thanks
But you have raised a PR that is just a bare bone implementation with no forward (throws NonImplementedError in this case)
Please donot blindly use AI and look what it is giving out before pushing
Hi sorry for the confusion the pr is still work in progress will make changes and revert |
Reference Issues/PRs
Fixes #2260
What does this implement/fix? Explain your changes.
This PR adds support for the Salesforce Moirai and Moirai-MoE foundation models into the v2 interface of pytorch-forecasting.
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
The new models are automatically picked up by the existing PyTorch Forecasting v2 testing framework (specifically test_all_v2), which iterates over registered models ending in _pkg_v2. We have run the test_all_estimators_v2.py suite to ensure they instantiate correctly and do not break the class registry.
Any other comments?
PR checklist
pre-commit install.To run hooks independent of commit, execute
pre-commit run --all-files