Skip to content

[ENH] Implement NBEATS family in v2 - #2373

Draft
Faakhir30 wants to merge 3 commits into
sktime:mainfrom
Faakhir30:nbeatsv2
Draft

[ENH] Implement NBEATS family in v2#2373
Faakhir30 wants to merge 3 commits into
sktime:mainfrom
Faakhir30:nbeatsv2

Conversation

@Faakhir30

@Faakhir30 Faakhir30 commented Aug 7, 2026

Copy link
Copy Markdown
Member

WIP

Reference Issues/PRs

What does this implement/fix? Explain your changes.

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

Any other comments?

PR checklist

  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Signed-off-by: Faakhir30 <zahidfaakhir@gmail.com>
Signed-off-by: Faakhir30 <zahidfaakhir@gmail.com>
@Faakhir30 Faakhir30 changed the title [ENH] Implement NBEATS in v2 [ENH] Implement NBEATS family in v2 Aug 7, 2026
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 24.42748% with 99 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@7bcf66c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ch_forecasting/models/nbeats/_nbeats_adapter_v2.py 19.35% 50 Missing ⚠️
pytorch_forecasting/models/nbeats/_nbeats_v2.py 22.91% 37 Missing ⚠️
...ytorch_forecasting/models/nbeats/_nbeats_pkg_v2.py 42.85% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2373   +/-   ##
=======================================
  Coverage        ?   86.66%           
=======================================
  Files           ?      178           
  Lines           ?    10296           
  Branches        ?        0           
=======================================
  Hits            ?     8923           
  Misses          ?     1373           
  Partials        ?        0           
Flag Coverage Δ
cpu 86.66% <24.42%> (?)
pytest 86.66% <24.42%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phoeenniixx phoeenniixx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have a suggestion - can you please add one model per PR? this makes it easy to review.

Meaning please add NBEATSKAN and NBEATSx in separate PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants