[BUG] burr iii implementation was using the wrong scipy method#953
Open
hrshx3o5o6 wants to merge 1 commit intosktime:mainfrom
Open
[BUG] burr iii implementation was using the wrong scipy method#953hrshx3o5o6 wants to merge 1 commit intosktime:mainfrom
scipy method#953hrshx3o5o6 wants to merge 1 commit intosktime:mainfrom
Conversation
scipy method
fkiraly
requested changes
Mar 21, 2026
Collaborator
fkiraly
left a comment
There was a problem hiding this comment.
Thanks!
By accident, this Pr seems to contain another one with unrelated content - can you please fix that?
5bfbfd9 to
ff86881
Compare
Author
|
Thanks for flagging that! I've cleaned up the branch now so it contains the BurrIII fix alone and have requested for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #952
What does this implement/fix? Explain your changes.
This PR fixes a critical bug in the
BurrIIIdistribution class where it incorrectly wrappedscipy.stats.burr12(Burr Type XII) instead ofscipy.stats.burr(Burr Type III).Changes made:
BurrIII._get_scipy_objectto returnscipy.stats.burr.BurrIIIto correctly accept both thecanddshape parameters (previously,dwas hardcoded to1).get_test_paramsto thoroughly test cases whered != 1.0.Does your contribution introduce a new dependency? If yes, which one?
No new dependencies.
What should a reviewer concentrate their feedback on?
scipy.stats.burrbehaves as expected with the newc,d, andscalemapping logic.Did you add any tests for the change?
Yes, the existing generic test suite
test_all_distrs.pythoroughly verifies the new parameters generated by the updatedget_test_paramsclass method.Any other comments?
N/A
PR checklist
For all contributions
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.