fix: [BUG] GeneralizedPareto: false log_pdf exact tag, missing#962
Open
JiwaniZakir wants to merge 1 commit intosktime:mainfrom
Open
fix: [BUG] GeneralizedPareto: false log_pdf exact tag, missing#962JiwaniZakir wants to merge 1 commit intosktime:mainfrom
JiwaniZakir wants to merge 1 commit intosktime:mainfrom
Conversation
…r:paramtype, add 3rd test params (sktime#961)
JiwaniZakir
requested review from
felipeangelimvieira and
fkiraly
as code owners
fkiraly
requested changes
Mar 21, 2026
Collaborator
fkiraly
left a comment
fkiraly
left a comment
There was a problem hiding this comment.
The tag is correct but the scipy adapter is not used correctly. The methods should all be removed, and the parameter loc renamed, so the scipy adapter can be used.
fkiraly
added
bug
module:probability&simulation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #961
GeneralizedParetoinskpro/distributions/gen_pareto.pyincorrectly claimedlog_pdfas an exact capability and was missing thedistr:paramtypetag entirely. Thelog_pdfmethod was inherited without a closed-form implementation, making the tag false. Removeslog_pdffromcapabilities:exactand adds"distr:paramtype": "parametric"to_tags. Expandsget_test_paramsfrom 2 to 3 parameter sets, adding array-valuedcand explicitindex/columnsto improve broadcast and shape coverage.