Skip to content

[ENH] Remove redundant method overrides in Skellam and FDist #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ANANYA542 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ENH] Remove redundant method overrides in Skellam and FDist #963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions skpro/distributions/f_dist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,31 +49,6 @@ def _get_scipy_param(self):
dfd = self._bc_params["dfd"]
return [], {"dfn": dfn, "dfd": dfd}

def _pdf(self, x):
dfn = self._bc_params["dfn"]
dfd = self._bc_params["dfd"]
return f.pdf(x, dfn, dfd)

def _cdf(self, x):
dfn = self._bc_params["dfn"]
dfd = self._bc_params["dfd"]
return f.cdf(x, dfn, dfd)

def _ppf(self, p):
dfn = self._bc_params["dfn"]
dfd = self._bc_params["dfd"]
return f.ppf(p, dfn, dfd)

def _mean(self):
dfn = self._bc_params["dfn"]
dfd = self._bc_params["dfd"]
return f.mean(dfn, dfd)

def _var(self):
dfn = self._bc_params["dfn"]
dfd = self._bc_params["dfd"]
return f.var(dfn, dfd)

@classmethod
def get_test_params(cls, parameter_set="default"):
"""Return test parameters for FDist."""
Expand Down
25 changes: 0 additions & 25 deletions skpro/distributions/skellam.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,31 +46,6 @@ def _get_scipy_param(self):
mu2 = self._bc_params["mu2"]
return [mu1, mu2], {}

def _pmf(self, x):
mu1 = self._bc_params["mu1"]
mu2 = self._bc_params["mu2"]
return skellam.pmf(x, mu1, mu2)

def _cdf(self, x):
mu1 = self._bc_params["mu1"]
mu2 = self._bc_params["mu2"]
return skellam.cdf(x, mu1, mu2)

def _ppf(self, p):
mu1 = self._bc_params["mu1"]
mu2 = self._bc_params["mu2"]
return skellam.ppf(p, mu1, mu2)

def _mean(self):
mu1 = self._bc_params["mu1"]
mu2 = self._bc_params["mu2"]
return skellam.mean(mu1, mu2)

def _var(self):
mu1 = self._bc_params["mu1"]
mu2 = self._bc_params["mu2"]
return skellam.var(mu1, mu2)

@classmethod
def get_test_params(cls, parameter_set="default"):
"""Return test parameters for Skellam."""
Expand Down
Loading