[ENH] Add BayesianConjugateGLMRegressor with conjugate priors#969
Open
arnavk23 wants to merge 26 commits intosktime:mainfrom
Open
[ENH] Add BayesianConjugateGLMRegressor with conjugate priors#969arnavk23 wants to merge 26 commits intosktime:mainfrom
BayesianConjugateGLMRegressor with conjugate priors#969arnavk23 wants to merge 26 commits intosktime:mainfrom
Conversation
The framework already ensures X and y are in the specified inner mtypes (pd_DataFrame_Table), so the pd.to_numeric coercion is unnecessary. Simplified to direct .to_numpy(dtype=float) conversions.
This reverts commit 62cdd79.
…m/arnavk23/skpro into mentorship-notes-arnav-kapoor
BayesianConjugateGLMRegressor with conjugate priors
Contributor
Author
|
@fkiraly @marrov Worked extensively on this. Please look through the docstrings, I think I added the estimator extensively but if there are suggestions on extending it further, open to the same. Also going through literature on this issue, if I find something will report (also if you think any literature applicable to this, do send). Sidebar, @fkiraly Will be falling this format of pr going forward, if there are ways to make this better, do tell. |
…cstyle compliant; docstring and formatting fixes; add g-prior and synthetic prior support.
…sure all parameters as attributes, and return PPC samples in correct shape. Run pre-commit and auto-format with black.
Contributor
Author
|
@fkiraly @marrov Key features added here:
|
…Regressor; ensure scikit-learn compliance and fix test errors.
…ressor; only assign first two values from _perform_bayesian_inference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #7
What does this implement/fix? Explain your changes.
This PR adds the
BayesianConjugateGLMRegressorestimator to theskpro.regression.bayesianmodule.Does your contribution introduce a new dependency? If yes, which one?
No new dependencies are introduced.
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
No new tests included in this commit.
Please verify if coverage is sufficient or if additional tests are needed.
Any other comments?
_updatemethod.PR checklist
For all contributions
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.