Fix data leakage in _LifelinesAdapter when y has multiple columns#971
Open
aditi-malviya666 wants to merge 1 commit intosktime:mainfrom
Open
Fix data leakage in _LifelinesAdapter when y has multiple columns#971aditi-malviya666 wants to merge 1 commit intosktime:mainfrom
aditi-malviya666 wants to merge 1 commit intosktime:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #947
What does this implement/fix? Explain your changes.
This PR fixes a data leakage issue in
_LifelinesAdapter.Previously, when
ycontained multiple columns, all columns were concatenated into the training DataFrame. Sincelifelinestreats any column not specified asduration_colorevent_colas covariates, this caused unintended leakage of target information into the feature set.The fix ensures that only:
Xy(used asduration_col)C(if provided)are included in the DataFrame passed to the lifelines estimator.
Additionally, a warning is raised when
ycontains multiple columns to inform the user that only the first column is used.Does your contribution introduce a new dependency? If yes, which one?
No new dependencies are introduced.
What should a reviewer concentrate their feedback on?
_fityis consistent with expected API behaviorC) and compatibility with lifelinesDid you add any tests for the change?
No new tests have been added yet, but the fix has been manually validated using a reproducible example that previously demonstrated leakage.
Any other comments?
This fix prevents unintended target leakage and aligns the adapter behavior with lifelines expectations.
PR checklist
For all contributions
For new estimators