fix(regression): return variance (σ²) instead of std dev (σ) in DummyProbaRegressor._predict_var#982
Open
tysoncung wants to merge 1 commit intosktime:mainfrom
Conversation
…ProbaRegressor._predict_var (sktime#975) _predict_var was returning self._sigma (standard deviation) instead of self._sigma ** 2 (variance), causing numerically incorrect results for any downstream usage of predict_var. Closes sktime#975
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DummyProbaRegressor._predict_varreturns the standard deviation (σ) of the training labels instead of the variance (σ²). This is a unit-mismatch bug —predict_varshould return variance, not standard deviation.Solution
Changed
self._sigmatoself._sigma ** 2in_predict_var, so the method correctly returns variance (σ²) as documented.Files Changed
skpro/regression/dummy.py: Fixed_predict_varto returnself._sigma ** 2instead ofself._sigmaVerification
Closes #975