[ENH] add isj bandwidth option to kernel base models#989
Open
NandiniDhanrale wants to merge 2 commits intosktime:mainfrom
Open
[ENH] add isj bandwidth option to kernel base models#989NandiniDhanrale wants to merge 2 commits intosktime:mainfrom
NandiniDhanrale wants to merge 2 commits intosktime:mainfrom
Conversation
Contributor
|
@NandiniDhanrale You can drop this test file. params6 in get_test_params already runs the ISJ path end-to-end through the framework. The "matches helper" test calls bandwidth_1d on both sides, so it's really just checking a == a. If you want to keep the degenerate fallback check, put it in test_bandwidth.py as a unit test on bw_isj_1d. |
Author
|
Addressing the duplicate-coverage point:
Re-ran:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"isj"as a supported automatic bandwidth rule forKernelMixtureNadarayaWatsonCDE.y_bandwidthto accept"isj"for the 1D target-kernel pathTesting
py -3.11 -m pytest -o addopts= skpro/regression/tests/test_bandwidth.py skpro/distributions/tests/test_kernel_mixture.py skpro/regression/tests/test_nadaraya_watson.py -qFixes #980