Bugfix/fix bayesian conjugate glm tests#996
Open
kindler-king wants to merge 27 commits intosktime:mainfrom
Open
Bugfix/fix bayesian conjugate glm tests#996kindler-king wants to merge 27 commits intosktime:mainfrom
kindler-king wants to merge 27 commits intosktime:mainfrom
Conversation
The framework already ensures X and y are in the specified inner mtypes (pd_DataFrame_Table), so the pd.to_numeric coercion is unnecessary. Simplified to direct .to_numpy(dtype=float) conversions.
This reverts commit 62cdd79.
…m/arnavk23/skpro into mentorship-notes-arnav-kapoor
…cstyle compliant; docstring and formatting fixes; add g-prior and synthetic prior support.
…sure all parameters as attributes, and return PPC samples in correct shape. Run pre-commit and auto-format with black.
…Regressor; ensure scikit-learn compliance and fix test errors.
…ressor; only assign first two values from _perform_bayesian_inference.
…ensive tests for BayesianConjugateGLMRegressor
kindler-king
requested review from
felipeangelimvieira and
fkiraly
as code owners
45 tasks
Contributor
|
@kindler-king Thank you for going through my pr. I really appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #7, complements #969
While reviewing PR #969 by @arnavk23, I found 3 bugs and noticed the test coverage could be substantially strengthened.
Bugs fixed in [_glm_conjugate.py]:
student_t.StudentT→t.TDistributionscale=→sigma=(TDistribution API)XᵀX, causing shape mismatch; alsofloat()crash on 2D matrix resultTests added ([test_bayesian_glm_conjugate_comprehensive.py]: