Skip to content

Commit 5756639

Browse files
authored
Merge pull request #54 from bartoval/last_observer_image
Last observer image
2 parents 7b2fa54 + 5b33a29 commit 5756639

17 files changed

+264
-228
lines changed

__tests__/REST.api.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ describe('RESTApi', () => {
396396
.mockResolvedValue({}); // Rest succeed
397397

398398
await expect(RESTApi.createDeployment()).resolves.not.toThrow();
399-
expect(mockAxiosFetch).toHaveBeenCalledTimes(11); // Total number of requests
399+
expect(mockAxiosFetch).toHaveBeenCalledTimes(10); // Total number of requests
400400
});
401401

402402
it('handles network errors during deployment deletion', async () => {
@@ -415,7 +415,7 @@ describe('RESTApi', () => {
415415
.mockResolvedValue({}); // Rest succeed
416416

417417
await expect(RESTApi.deleteDeployment()).resolves.not.toThrow();
418-
expect(mockAxiosFetch).toHaveBeenCalledTimes(11); // Total number of requests
418+
expect(mockAxiosFetch).toHaveBeenCalledTimes(10); // Total number of requests
419419
});
420420
});
421421
});

src/console/API/REST.api.ts

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,20 +26,20 @@ import {
2626
serviceAccountPath,
2727
configMapPath,
2828
routePath,
29-
linkPath
29+
linkPath,
30+
jobPath
3031
} from './REST.paths';
3132
import { convertSiteCRToSite } from './REST.utils';
3233
import certificateData from '../deployment/Certificate.json';
3334
import configMapPromData from '../deployment/ConfigMap-Prom.json';
34-
import configMapData from '../deployment/ConfigMap.json';
35-
import deploymentPromData from '../deployment/Deployment-Prom.json';
3635
import deploymentData from '../deployment/Deployment.json';
36+
import jobData from '../deployment/Job.json';
3737
import roleData from '../deployment/Role.json';
3838
import roleBindingData from '../deployment/RoleBinding.json';
39-
import RouteData from '../deployment/Route.json';
40-
import servicePromData from '../deployment/Service-Prom.json';
39+
import routeData from '../deployment/Route.json';
4140
import serviceData from '../deployment/Service.json';
4241
import serviceAccountData from '../deployment/ServiceAccount.json';
42+
import serviceAccountSetupData from '../deployment/ServiceAccountSetup.json';
4343
import { ListCrdResponse, PartialDeploymentResponse } from '../interfaces/CRD_Base';
4444
import { SiteView } from '../interfaces/REST.interfaces';
4545

@@ -182,13 +182,12 @@ export const RESTApi = {
182182
{ path: roleBindPath(), data: roleBindingData },
183183
{ path: certificatePath(), data: certificateData },
184184
{ path: deploymentsPath(), data: deploymentData },
185-
{ path: deploymentsPath(), data: deploymentPromData },
185+
{ path: jobPath(), data: jobData },
186186
{ path: servicePath(), data: serviceData },
187-
{ path: servicePath(), data: servicePromData },
187+
{ path: serviceAccountPath(), data: serviceAccountSetupData },
188188
{ path: serviceAccountPath(), data: serviceAccountData },
189-
{ path: configMapPath(), data: configMapData },
190189
{ path: configMapPath(), data: configMapPromData },
191-
{ path: routePath(), data: RouteData }
190+
{ path: routePath(), data: routeData }
192191
];
193192

194193
const promises = requests.map(({ path, data }) =>
@@ -208,16 +207,15 @@ export const RESTApi = {
208207

209208
deleteDeployment: async (): Promise<void> => {
210209
const requests = [
211-
{ path: `${routePath()}/${RouteData.metadata.name}` },
210+
{ path: `${routePath()}/${routeData.metadata.name}` },
212211
{ path: `${rolePath()}/${roleData.metadata.name}` },
213212
{ path: `${roleBindPath()}/${roleBindingData.metadata.name}` },
214213
{ path: `${certificatePath()}/${certificateData.metadata.name}` },
215214
{ path: `${deploymentsPath()}/${deploymentData.metadata.name}` },
216-
{ path: `${deploymentsPath()}/${deploymentPromData.metadata.name}` },
215+
{ path: `${deploymentsPath()}/${jobData.metadata.name}` },
217216
{ path: `${servicePath()}/${serviceData.metadata.name}` },
218-
{ path: `${servicePath()}/${servicePromData.metadata.name}` },
217+
{ path: `${serviceAccountPath()}/${serviceAccountSetupData.metadata.name}` },
219218
{ path: `${serviceAccountPath()}/${serviceAccountData.metadata.name}` },
220-
{ path: `${configMapPath()}/${configMapData.metadata.name}` },
221219
{ path: `${configMapPath()}/${configMapPromData.metadata.name}` }
222220
];
223221

src/console/API/REST.paths.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ const BASE_PATHS = {
77
cr: `${K8S_PREFIX_PATH}apis/${GROUP}/${API_VERSION}/namespaces`,
88
rbac: `${K8S_PREFIX_PATH}apis/rbac.authorization.k8s.io/v1/namespaces`,
99
k8s: `${K8S_PREFIX_PATH}api/v1/namespaces`,
10-
route: `${K8S_PREFIX_PATH}apis/route.openshift.io/v1/namespaces`
10+
route: `${K8S_PREFIX_PATH}apis/route.openshift.io/v1/namespaces`,
11+
batch: `${K8S_PREFIX_PATH}apis/batch/v1/namespaces`
1112
};
1213

1314
// Helper to build namespace paths
@@ -52,3 +53,4 @@ export const servicePath = () => buildPath(BASE_PATHS.k8s, 'services');
5253
export const serviceAccountPath = () => buildPath(BASE_PATHS.k8s, 'serviceaccounts');
5354

5455
export const routePath = () => buildPath(BASE_PATHS.route, 'routes');
56+
export const jobPath = () => buildPath(BASE_PATHS.batch, 'jobs');

src/console/deployment/Certificate.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,13 @@
22
"apiVersion": "skupper.io/v2alpha1",
33
"kind": "Certificate",
44
"metadata": {
5-
"name": "skupper-management-client"
5+
"name": "skupper-network-observer-client",
6+
"labels": {
7+
"app.kubernetes.io/name": "network-observer",
8+
"app.kubernetes.io/instance": "skupper-network-observer",
9+
"app.kubernetes.io/version": "2.0.0",
10+
"app.kubernetes.io/part-of": "skupper-network-observer"
11+
}
612
},
713
"spec": {
814
"ca": "skupper-local-ca",
Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
11
{
22
"apiVersion": "v1",
3-
"data": {
4-
"prometheus.yml": "global:\n scrape_interval: 15s\n evaluation_interval: 15s\nalerting:\n alertmanagers:\n - static_configs:\n - targets:\nrule_files:\nscrape_configs:\n - job_name: network-observer-service\n kubernetes_sd_configs:\n - role: service\n kubeconfig_file: \"\"\n follow_redirects: true\n enable_http2: true\n namespaces:\n own_namespace: true\n scheme: https\n tls_config:\n ca_file: /etc/tls/openshift/service-ca.crt\n follow_redirects: true\n enable_http2: true\n relabel_configs:\n - source_labels: [__meta_kubernetes_service_label_app_kubernetes_io_name]\n regex: network-observer\n action: keep\n - source_labels: [__meta_kubernetes_service_port_name]\n regex: https\n action: keep\n - action: labelmap\n regex: __meta_kubernetes_service_label_(.+)\n replacement: $1\n - source_labels: [__meta_kubernetes_namespace]\n target_label: namespace\n - source_labels: [__meta_kubernetes_service_name]\n target_label: service\n",
5-
"web-config.yml": "# TLS configuration.\n#\n#tls_server_config:\n# cert_file: /etc/tls/certs/tls.crt\n# key_file: /etc/tls/certs/tls.key\n"
6-
},
73
"kind": "ConfigMap",
84
"metadata": {
9-
"name": "prometheus-server-config",
5+
"name": "skupper-network-observer-prometheus",
106
"labels": {
7+
"app.kubernetes.io/name": "network-observer",
8+
"app.kubernetes.io/instance": "skupper-network-observer",
9+
"app.kubernetes.io/version": "2.0.0",
1110
"app.kubernetes.io/part-of": "skupper-network-observer"
1211
}
12+
},
13+
"data": {
14+
"prometheus.yml": "global:\n scrape_interval: 15s\n evaluation_interval: 15s\nalerting:\n alertmanagers:\n - static_configs:\n - targets:\nscrape_configs:\n - job_name: \"network-observer-local\"\n scheme: http\n follow_redirects: true\n enable_http2: true\n static_configs:\n - targets: [ \"localhost:8080\" ]\n"
1315
}
1416
}

src/console/deployment/ConfigMap.json

Lines changed: 0 additions & 13 deletions
This file was deleted.

src/console/deployment/Deployment-Prom.json

Lines changed: 0 additions & 87 deletions
This file was deleted.

0 commit comments

Comments
 (0)