Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions __tests__/REST.api.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ describe('RESTApi', () => {
.mockResolvedValue({}); // Rest succeed

await expect(RESTApi.createDeployment()).resolves.not.toThrow();
expect(mockAxiosFetch).toHaveBeenCalledTimes(11); // Total number of requests
expect(mockAxiosFetch).toHaveBeenCalledTimes(10); // Total number of requests
});

it('handles network errors during deployment deletion', async () => {
Expand All @@ -415,7 +415,7 @@ describe('RESTApi', () => {
.mockResolvedValue({}); // Rest succeed

await expect(RESTApi.deleteDeployment()).resolves.not.toThrow();
expect(mockAxiosFetch).toHaveBeenCalledTimes(11); // Total number of requests
expect(mockAxiosFetch).toHaveBeenCalledTimes(10); // Total number of requests
});
});
});
24 changes: 11 additions & 13 deletions src/console/API/REST.api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,20 +26,20 @@ import {
serviceAccountPath,
configMapPath,
routePath,
linkPath
linkPath,
jobPath
} from './REST.paths';
import { convertSiteCRToSite } from './REST.utils';
import certificateData from '../deployment/Certificate.json';
import configMapPromData from '../deployment/ConfigMap-Prom.json';
import configMapData from '../deployment/ConfigMap.json';
import deploymentPromData from '../deployment/Deployment-Prom.json';
import deploymentData from '../deployment/Deployment.json';
import jobData from '../deployment/Job.json';
import roleData from '../deployment/Role.json';
import roleBindingData from '../deployment/RoleBinding.json';
import RouteData from '../deployment/Route.json';
import servicePromData from '../deployment/Service-Prom.json';
import routeData from '../deployment/Route.json';
import serviceData from '../deployment/Service.json';
import serviceAccountData from '../deployment/ServiceAccount.json';
import serviceAccountSetupData from '../deployment/ServiceAccountSetup.json';
import { ListCrdResponse, PartialDeploymentResponse } from '../interfaces/CRD_Base';
import { SiteView } from '../interfaces/REST.interfaces';

Expand Down Expand Up @@ -182,13 +182,12 @@ export const RESTApi = {
{ path: roleBindPath(), data: roleBindingData },
{ path: certificatePath(), data: certificateData },
{ path: deploymentsPath(), data: deploymentData },
{ path: deploymentsPath(), data: deploymentPromData },
{ path: jobPath(), data: jobData },
{ path: servicePath(), data: serviceData },
{ path: servicePath(), data: servicePromData },
{ path: serviceAccountPath(), data: serviceAccountSetupData },
{ path: serviceAccountPath(), data: serviceAccountData },
{ path: configMapPath(), data: configMapData },
{ path: configMapPath(), data: configMapPromData },
{ path: routePath(), data: RouteData }
{ path: routePath(), data: routeData }
];

const promises = requests.map(({ path, data }) =>
Expand All @@ -208,16 +207,15 @@ export const RESTApi = {

deleteDeployment: async (): Promise<void> => {
const requests = [
{ path: `${routePath()}/${RouteData.metadata.name}` },
{ path: `${routePath()}/${routeData.metadata.name}` },
{ path: `${rolePath()}/${roleData.metadata.name}` },
{ path: `${roleBindPath()}/${roleBindingData.metadata.name}` },
{ path: `${certificatePath()}/${certificateData.metadata.name}` },
{ path: `${deploymentsPath()}/${deploymentData.metadata.name}` },
{ path: `${deploymentsPath()}/${deploymentPromData.metadata.name}` },
{ path: `${deploymentsPath()}/${jobData.metadata.name}` },
{ path: `${servicePath()}/${serviceData.metadata.name}` },
{ path: `${servicePath()}/${servicePromData.metadata.name}` },
{ path: `${serviceAccountPath()}/${serviceAccountSetupData.metadata.name}` },
{ path: `${serviceAccountPath()}/${serviceAccountData.metadata.name}` },
{ path: `${configMapPath()}/${configMapData.metadata.name}` },
{ path: `${configMapPath()}/${configMapPromData.metadata.name}` }
];

Expand Down
4 changes: 3 additions & 1 deletion src/console/API/REST.paths.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ const BASE_PATHS = {
cr: `${K8S_PREFIX_PATH}apis/${GROUP}/${API_VERSION}/namespaces`,
rbac: `${K8S_PREFIX_PATH}apis/rbac.authorization.k8s.io/v1/namespaces`,
k8s: `${K8S_PREFIX_PATH}api/v1/namespaces`,
route: `${K8S_PREFIX_PATH}apis/route.openshift.io/v1/namespaces`
route: `${K8S_PREFIX_PATH}apis/route.openshift.io/v1/namespaces`,
batch: `${K8S_PREFIX_PATH}apis/batch/v1/namespaces`
};

// Helper to build namespace paths
Expand Down Expand Up @@ -52,3 +53,4 @@ export const servicePath = () => buildPath(BASE_PATHS.k8s, 'services');
export const serviceAccountPath = () => buildPath(BASE_PATHS.k8s, 'serviceaccounts');

export const routePath = () => buildPath(BASE_PATHS.route, 'routes');
export const jobPath = () => buildPath(BASE_PATHS.batch, 'jobs');
8 changes: 7 additions & 1 deletion src/console/deployment/Certificate.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,13 @@
"apiVersion": "skupper.io/v2alpha1",
"kind": "Certificate",
"metadata": {
"name": "skupper-management-client"
"name": "skupper-network-observer-client",
"labels": {
"app.kubernetes.io/name": "network-observer",
"app.kubernetes.io/instance": "skupper-network-observer",
"app.kubernetes.io/version": "2.0.0",
"app.kubernetes.io/part-of": "skupper-network-observer"
}
},
"spec": {
"ca": "skupper-local-ca",
Expand Down
12 changes: 7 additions & 5 deletions src/console/deployment/ConfigMap-Prom.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
{
"apiVersion": "v1",
"data": {
"prometheus.yml": "global:\n scrape_interval: 15s\n evaluation_interval: 15s\nalerting:\n alertmanagers:\n - static_configs:\n - targets:\nrule_files:\nscrape_configs:\n - job_name: network-observer-service\n kubernetes_sd_configs:\n - role: service\n kubeconfig_file: \"\"\n follow_redirects: true\n enable_http2: true\n namespaces:\n own_namespace: true\n scheme: https\n tls_config:\n ca_file: /etc/tls/openshift/service-ca.crt\n follow_redirects: true\n enable_http2: true\n relabel_configs:\n - source_labels: [__meta_kubernetes_service_label_app_kubernetes_io_name]\n regex: network-observer\n action: keep\n - source_labels: [__meta_kubernetes_service_port_name]\n regex: https\n action: keep\n - action: labelmap\n regex: __meta_kubernetes_service_label_(.+)\n replacement: $1\n - source_labels: [__meta_kubernetes_namespace]\n target_label: namespace\n - source_labels: [__meta_kubernetes_service_name]\n target_label: service\n",
"web-config.yml": "# TLS configuration.\n#\n#tls_server_config:\n# cert_file: /etc/tls/certs/tls.crt\n# key_file: /etc/tls/certs/tls.key\n"
},
"kind": "ConfigMap",
"metadata": {
"name": "prometheus-server-config",
"name": "skupper-network-observer-prometheus",
"labels": {
"app.kubernetes.io/name": "network-observer",
"app.kubernetes.io/instance": "skupper-network-observer",
"app.kubernetes.io/version": "2.0.0",
"app.kubernetes.io/part-of": "skupper-network-observer"
}
},
"data": {
"prometheus.yml": "global:\n scrape_interval: 15s\n evaluation_interval: 15s\nalerting:\n alertmanagers:\n - static_configs:\n - targets:\nscrape_configs:\n - job_name: \"network-observer-local\"\n scheme: http\n follow_redirects: true\n enable_http2: true\n static_configs:\n - targets: [ \"localhost:8080\" ]\n"
}
}
13 changes: 0 additions & 13 deletions src/console/deployment/ConfigMap.json

This file was deleted.

87 changes: 0 additions & 87 deletions src/console/deployment/Deployment-Prom.json

This file was deleted.

Loading
Loading