Enhanced Labeling Configuration #2352
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AryanP123
requested review from
c-kruse,
fgiorgetti and
nluaces
as code owners
c-kruse
reviewed
Jan 22, 2026
| if target == nil { | ||
| continue | ||
| } | ||
| req, err := k8slabels.Parse(selector) |
Contributor
There was a problem hiding this comment.
@AryanP123 I'd really rather see this cached in the Registry - probably ideally up-front on Update, but on first access is probably okay also.
It is possible that Registry.filter is going to get called a lot, so logging "Ignoring label-template" each time could get noisy, and rerunning k8slabels.Parse could end up churning lots of memory+cpu cycles in the long run.
AryanP123
force-pushed
the
label-config
branch
from
defb559 to
2d6b13c
Compare
Member
|
@AryanP123 @c-kruse Looking at the original issue and to what this change is doing, it seems like the annotations defined in the ConfigMap are not going to be replicated across the target services of a provided |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add labelSelector support; set listener Service label to name; unit tests
Fixes #2109