Fixes HA router deployment selector overlap #2363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In HA mode, both router deployments (skupper-router and skupper-router-2) share identical label selectors (skupper.io/component: router), causing kubectl to select pods from either deployment unpredictably. This is an otherwise harmless misconfiguration. Adds the skupper.io/group label to each deployment's matchLabels selector so that each deployment only selects its own pods. Signed-off-by: Christian Kruse <christian@c-kruse.com>
Contributor
|
Fix correctly adds unique skupper.io/group labels to deployment selectors. Tests pass, lgtm. |
AryanP123
approved these changes
Jan 26, 2026
|
lgtm |
JPadovano1483
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In HA mode, both router deployments (skupper-router and skupper-router-2) share identical label selectors (skupper.io/component: router), causing kubectl to select pods from either deployment unpredictably.
Adds the skupper.io/group label to each deployment's matchLabels selector so that each deployment only selects its own pods. Fixes #2299