Add Splitter + FlapperMom => SplitterMom + DAI => USDS #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Splitter * Remove endgame-toolkit dep * Use GemMock * Skip reward when burning 100% * Add setRewardsDuration test * Refactor splitter & flapper init scripts * Dummy change to force github refresh * Revert "Dummy change to force github refresh" This reverts commit 44aff8f. * Group storage vars together * Update src/Splitter.sol Co-authored-by: sunbreak1211 <[email protected]> * Remove farm_ cache * Remove setting MCD_FLAP key in chainlog * Cleanups * Add duration change tests * Update test/mocks/StakingRewardsMock.sol Co-authored-by: sunbreak1211 <[email protected]> * Add sanity checks for immutables * Update deploy/FlapperInit.sol Co-authored-by: sunbreak1211 <[email protected]> * Fix alignment * Update checkChangeRewardDuration * Add mention of Splitter to README.md * Simplify testKickBurnOnly * Always rewrite PIP_MKR price in tests * Add event * Update README.md Co-authored-by: oldchili <[email protected]> * Update README.md Co-authored-by: oldchili <[email protected]> * Update src/Splitter.sol Co-authored-by: oldchili <[email protected]> * Add note and test related to very small burn values * Remove minBurn detail from README * Add burn not zero sanity check * Use divup in testKickLowBurn * Add rate limit to Splitter * Add notice to farm mock * Receive total amount of consumed DAI (#14) * lot now represents total consumed dai * Remove local change * bought => buy * Update ABDK link to correct line Co-authored-by: telome <[email protected]> * Update test/FlapperUniV2.t.sol Co-authored-by: telome <[email protected]> * Add testEquivalenceToSellLotAndDeposit * Remove only in comment * Use UNIV2_DAI_MKR_PAIR explicitly in test * Refactor testEquivalenceToSellLotAndDeposit --------- Co-authored-by: telome <[email protected]> * Support also NST in Splitter init validation * Update farm mock * lot now represents total consumed dai * Update test/FlapperUniV2.t.sol Co-authored-by: telome <[email protected]> * Simplify testKickBurnOnly * Add note and test related to very small burn values * Remove minBurn detail from README * Add rate limit to Splitter * Remove hop from flappers * Fix README * Address review comments * Fix rebase * Use hop as rewardsDuration * Use removeAddress * Use SplitterMock * Update test/FlapperUniV2SwapOnly.t.sol Co-authored-by: oldchili <[email protected]> * Rename flapper kick -> exec * Address review comments * Exit dai to flapper * Update src/Splitter.sol Co-authored-by: sunbreak1211 <[email protected]> * Update test/mocks/SplitterMock.sol Co-authored-by: sunbreak1211 <[email protected]> * Fix nits * Sanity check mom's splitter * Fix README * Update README.md Co-authored-by: sunbreak1211 <[email protected]> * Update README.md Co-authored-by: sunbreak1211 <[email protected]> * Update test/FlapperUniV2.t.sol Co-authored-by: sunbreak1211 <[email protected]> * Update test/Splitter.t.sol Co-authored-by: sunbreak1211 <[email protected]> --------- Co-authored-by: telome <> Co-authored-by: sunbreak1211 <[email protected]> Co-authored-by: oldchili <[email protected]>
* Fix Babylonian.sqrt * Move live check to splitter * Remove dangling daiJoin approvals * Add bump multiple of RAY check * Fix typo and regorg storage * Remove redundant line * Add check for farm's rewardsToken * Add sanity check for wrapper's divisor * Update src/Splitter.sol Co-authored-by: oldchili <[email protected]> * Add `live` sanity check --------- Co-authored-by: telome <> Co-authored-by: oldchili <[email protected]>
* Add Splitter audit report * Rename reports --------- Co-authored-by: telome <>
* Make farm upgradeable in Splitter * Spacing * Save farm key * Check hop wasn't empty * Check farm again in splitter constructor * Add comment * Change comment Co-authored-by: telome <[email protected]> * Readme Addition and Minor Comment Change (#23) * Add farm param to readme, change order * Minor change * Rename function and add comment * Remove spaces --------- Co-authored-by: telome <[email protected]> Co-authored-by: oldchili <[email protected]>
* Replace dai by nst * Add missing renaming * Revert renaming for tests excepting the mandatory cases
|
|
* Migrate tests to use USDS and SKY * Some fixes * Fix styling * More styling fixes * Standardize use of pips for tests and make use more logic prices for the assets
telome
approved these changes
Sep 25, 2024
14 tasks
oldchili
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.