This repository was archived by the owner on Oct 8, 2024. It is now read-only.
Open
Conversation
a3c9129 to
65b4969
Compare
a09d035 to
8d6a8f1
Compare
olivdb
reviewed
Nov 29, 2021
olivdb
reviewed
Nov 29, 2021
olivdb
reviewed
Nov 29, 2021
olivdb
reviewed
Nov 29, 2021
Rename methods in router and bridge
hexonaut
suggested changes
Dec 8, 2021
Contributor
hexonaut
left a comment
There was a problem hiding this comment.
Haven't looked at tests yet. Some changes needed, but overall mostly looks good.
hexonaut
reviewed
Dec 10, 2021
Address Sam's review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a WormholeBridge that allows for fast withdrawals. Releated: https://github.com/makerdao/dss-wormhole