Skip to content

Commit 4931fbc

Browse files
apply suggestions
1 parent 61630f4 commit 4931fbc

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

spell/star-spell-reviewer-checklist.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -150,12 +150,12 @@ This section outlines the review process and provides concrete action items for
150150

151151
### StarGuard execution
152152
- [ ] IF a [StarGuard module](https://github.com/sky-ecosystem/star-guard) is onboarded for this Star, the following additional checks are done:
153-
- [ ] The spell exposes view-only interface `function isExecutable() external view returns (bool result)`.
154-
- [ ] `isExecutable` either simply returns `true` or implements additional logic communicated via the relevant forum post (e.g.: by describing "earliest launch date" or "office hours" logic, etc).
155-
- [ ] The test is preset to ensure that `isExecutable` outputs `true` before `StarGuard.maxDelay()` expires the spell.
156-
- [ ] Third-party actors can not take advantage of the fact that Spell will be executed in a later block than the Core spell, otherwise suggest `direct execution`.
157-
- [ ] IF Prime spell can not be executed in a later block OR have to be executed sequentially to another Prime spell, `direct execution` is clearly proposed in the forum post together with elaborated explanation why it is needed.
158-
- [ ] The `direct execution` explanation makes sense on the technical level and can not be circumvented by the use of `isExecutable()` interface.
153+
- [ ] The spell exposes view-only interface `function isExecutable() external view returns (bool result)`.
154+
- [ ] `isExecutable` either simply returns `true` or implements additional logic communicated via the relevant forum post (e.g.: by describing "earliest launch date" or "office hours" logic, etc).
155+
- [ ] The test ensures the spell is executable before expiration (i.e. `isExecutable` outputs `true` before `StarGuard.maxDelay()` is passed).
156+
- [ ] Third-party actors can not take advantage of the fact that Spell will be executed in a later block than the Core spell, otherwise suggest `direct execution`.
157+
- [ ] IF Prime spell can not be executed in a later block OR have to be executed sequentially to another Prime spell, `direct execution` is clearly mentioned in the forum post together with elaborated explanation why it is needed.
158+
- [ ] The `direct execution` explanation makes sense on the technical level and can not be circumvented by the use of `isExecutable()` interface.
159159

160160
#### On-boarding New Contracts
161161
- LIST every new contract present in the spell:
@@ -278,7 +278,7 @@ EXECUTED_TESTS_LOGS
278278
- [ ] The spell address, the codehash and the direct execution are posted by the crafter in the `#govops` in the `XXX spell YYYY-MM-DD deployed to 0x… with hash 0x…, direct execution: yes / no` format.
279279
- [ ] Posted spell address matches the spell evaluated above.
280280
- [ ] Posted spell codehash matches the one noted down above.
281-
- [ ] Posted direct execution matches expected value.
281+
- [ ] Posted direct execution value matches the forum post.
282282
- [ ] Confirm the address (via a separate "reply to" message, restating the address to avoid edits).
283283
- [ ] Ensure that no changes were made to the code since the spell was deployed and archived.
284284
- [ ] Approve spell PR for merge via 'Approve' review option.

0 commit comments

Comments
 (0)