You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* Add comments to the spell based on the relevant [Exec Sheet](https://docs.google.com/spreadsheets/d/1w_z5WpqxzwreCcaveB2Ye1PP5B8QAHDglzyxKHG3CHw)
70
69
* [ ] Copy every _Section text_ from the Exec Sheet as comment to the spell code
71
70
* [ ] Surround the comment by the set of dashes (e.g. `// ----- Section text -----`)
72
71
* [ ] Copy every _Instruction text_ from the Exec Sheet (e.g. `// Instruction text`)
73
72
* [ ] Add newline above every _Instruction text_
74
73
* [ ] Copy every `Reasoning URL` and `Authority URL` from the Exec Sheet as a comment under relevant section or instruction in the spell code (depending on the row the link is present)
75
74
* [ ] For every `Reasoning URL` and `Authority URL`, add prefix derived from the url itself:
76
-
* `// Executive Vote:` IF URL starts with `https://vote.makerdao.com/executive/`
77
-
* `// Poll:` IF URL starts with `https://vote.makerdao.com/polling/`
78
-
* `// Forum:` IF URL starts with `https://forum.makerdao.com/t/`
79
-
* `// MIP:` IF URL starts with `https://mips.makerdao.com/mips/details/`
75
+
* `// Executive Vote:` if URL starts with `https://vote.sky.money/executive/`
76
+
* `// Poll:` if URL starts with `https://vote.sky.money/polling/`
77
+
* `// Forum:` if URL starts with `https://forum.sky.money/t/`
78
+
* `// MIP:` if URL starts with `https://mips.makerdao.com/mips/details/`
79
+
* `// Atlas:` if URL starts with `https://sky-atlas.powerhouse.io/`
80
80
* [ ] IF an action in the spell doesn't have relevant instruction (e.g.: ChainLog version bump), add the explanation below prefixed with `// Note:`
81
81
* [ ] IF an instruction can not be directly taken, add a comment below prefixed with `// Note:` (e.g.: `// Note: see dao_resolutions variable declared above`)
* [ ] Open draft PR on `spells-mainnet` titled `Mainnet spell YYYY-MM-DD` where `YYYY-MM-DD` is the expected target date of the spell
87
86
* [ ] Assign PR to yourself
87
+
* [ ] CI tests PASS
88
88
* Add content based on the provided Exec Sheet
89
89
* [ ] Ensure solc version is `0.8.16`
90
90
* [ ] Office hours is `true` IF spell introduces a major change that can affect external parties (e.g.: keepers are affected in case of collateral offboarding), OTHERWISE explicitly set to `false`
* [ ] Prefer using `DssExecLib` actions where possible (to avoid adding interfaces where not required)
96
-
* [ ] Avoid multi-import layout / importing from `Interfaces.sol` (see [issue #69](https://github.com/makerdao/dss-interfaces/issues/69))
97
-
* [ ] Prefer single import layout (e.g. `import {VatAbstract} from "dss-interfaces/dss/VatAbstract.sol";`)
96
+
* [ ] Avoid multi-import layout / importing from `Interfaces.sol` (see [issue #69](https://github.com/sky-ecosystem/dss-interfaces/issues/69))
97
+
* [ ] Prefer single import layout (e.g. `import {VatAbstract} from "dss-interfaces/dss/VatAbstract.sol";`)
98
98
* [ ] Use static interfaces IF not present in `dss-interfaces` OR present in `dss-interfaces` but outdated OR only a few function interfaces are needed
99
99
* IF new collateral is onboarded
100
100
* Deploy `Join` contract (check which one is required)
101
-
* [ ] Use [JoinFab](https://github.com/makerdao/JoinFab) to deploy
101
+
* [ ] Use [JoinFab](https://github.com/sky-ecosystem/JoinFab) to deploy
102
102
* [ ] Ensure Etherscan Verification
103
103
* [ ] Make sure AGPLv3 is specified and used
104
104
* [ ] IF flatten, consider removing `HEVM` interface artifacts
105
105
* Deploy `Clip` contract
106
-
* [ ] Use [ClipFab](https://github.com/makerdao/dss-deploy) to deploy
106
+
* [ ] Use [ClipFab](https://github.com/sky-ecosystem/dss-deploy) to deploy
107
107
* [ ] Ensure Etherscan Verification
108
108
* [ ] Make sure AGPLv3 is specified and used
109
109
* Deploy `Calc` contract (check which one is required)
110
-
* [ ] Use [CalcFab](https://github.com/makerdao/dss-deploy) to deploy
110
+
* [ ] Use [CalcFab](https://github.com/sky-ecosystem/dss-deploy) to deploy
111
111
* [ ] Note: automatically verified on etherscan
112
112
* [ ] Check if oracle deployment is required (e.g. univ3-lp-oracle, new ilk pip, ...) with responsible ecosystem actor
113
113
* IF addresses are used in the spell
114
114
* [ ] Use `immutable` visibility when declaring addresses using `DssExecLib.getChangelogAddress`, OTHERWISE use `constant` for statically defined addresses
115
-
* [ ] Fetch addresses as type `address` and wrap with `Like` suffix interfaces inline (when making calls), EXCEPT `MKR` and vesting contracts
116
-
* [ ] Use the [DssExecLib address helpers](https://github.com/makerdao/dss-exec-lib/blob/master/src/DssExecLib.sol#L166) where possible (e.g. `DssExecLib.vat()`)
117
-
* [ ] Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. `MCD_VAT` rather than `vat`), EXCEPT where the archive pattern differs from this pattern (e.g. `MKR`)
115
+
* [ ] Fetch addresses as type `address` and wrap with `Like` suffix interfaces inline (when making calls), EXCEPT where the archive pattern differs from this pattern (e.g. SKY)
116
+
* [ ] Use the [DssExecLib address helpers](https://github.com/sky-ecosystem/dss-exec-lib/blob/master/src/DssExecLib.sol#L192) where possible (e.g. `DssExecLib.vat()`)
117
+
* [ ] Where addresses are fetched from the ChainLog, the variable name must match the value of the ChainLog key for that address (e.g. `MCD_VAT` rather than `vat`), EXCEPT where the archive pattern differs from this pattern
118
118
* IF new addresses need to be added to the ChainLog
119
119
* [ ] Add new addresses to the ChainLog
120
120
* [ ] Increment ChainLog version, according to the update type
121
121
* Major -> New Vat (++.0.0)
122
122
* Minor -> Core Module (DSS) Update (e.g. Flapper) (0.++.0)
123
123
* Patch -> Collateral addition or addition/modification (0.0.++)
124
124
* [ ] New addresses are added to the `addresses_mainnet.sol`
125
-
* [ ] Changes are tested via `testNewOrUpdatedChainlogValues`
125
+
* [ ] Additions are tested via `testAddedChainlogKeys`
126
+
* [ ] Removals are tested via `testRemovedChainlogKeys`
126
127
* [ ] Adjust system values, collateral values inside `config.sol`
127
128
* [ ] Ensure every spell variable is declared as public/internal
* Collect any problems noticed during the spell, propose concrete improvements to make it constructive
260
261
* Prefix your message with `Initiating retro:` for clarity
261
262
* IF there is nothing to discuss, post `Initiating retro: nothing to discuss from my side`
262
-
* IF [`MegaPoker`-related](https://github.com/makerdao/megapoker/blob/master/src/MegaPoker.sol) updates are present in the spell (oracles are replaced, collaterals are onboarded or offboarded, etc)
263
+
* IF [`MegaPoker`-related](https://github.com/sky-ecosystem/megapoker/blob/master/src/MegaPoker.sol) updates are present in the spell (oracles are replaced, collaterals are onboarded or offboarded, etc)
263
264
* [ ] Inform EA responsible for maintaining `MegaPoker` contract
264
265
* Ensure `MegaPoker` contract is updated
265
266
* [ ] Coordinate with EA responsible for maintaining `MegaPoker` and TechOps
0 commit comments