-
Notifications
You must be signed in to change notification settings - Fork 9
Chore: create d3m checklist #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TL;DR: 1 fix and several grammar/phrasing nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some redundant checks that might potentially be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds D3M onboarding checklist.
Superset of all D3M onboarding action list
dss-direct-deposit/D3MCoreInstance,dss-direct-deposit/D3MInit,dss-direct-deposit/D3MInstanceindependenciesdir (from here)plan: plan contract addresspool: pool contract addressoracle: oracle contract addresshub: D3M hub contract address (from chainlog)mom: D3M mom contract address (from chainlog)maxLine: Debt ceiling (auto line value)gap: Max Value between current debt and line to be set (auto line value)ttl: Min time to pass before a new increase (auto line value)tau: Time until you can write off the debt [sec]king: address who will get rewardsadai: adai addressstableDebt: stableDebtToken addressvariableDebt: variableDebtToken addressbuffer: Target DAI liquidity to keep in the pool [WAD]adai: adai token addressD3MAaveV2TypeRateTargetPlan.solcontract was deployedD3MAaveRateTargetPlanConfiginD3MInit.solshould be used. WhenD3MAaveTypeBufferPlan.solcontract was deployed we can useD3MAaveBufferPlanConfigking: address who will get rewardscdai: cdai token address[comptroller](https://github.com/compound-finance/compound-protocol/blob/master/contracts/Comptroller.sol): comptroller addresscomp: address of the COMP tokenbarb: target Interest Rate Per Block [wad]cdai: cdai token addresstack: supported rate modelsdelegate: cDai supported implementationsvault: ERC4626 standard vault addressoperator: D3M Operator Plan addressD3MInit.initCommon(code), in d3m repository)ilk.pooladdress inhubcontract (code)ilk.planaddress inhubcontract (code)ilk.tauvalue inhubcontract (code)hubaddress inoraclecontract (code)ilk.pip(price feed)in spotter (code)ilk.mat(liquidation ratio)in spotter (code)vat(code)jug(code)ilk.lineinvat(code)ilktoILK_REGISTRY(code)pool,plan,oraclecontract to chainlog withprefix(code)pool.hubaddress matches DIRECT_HUB address on chainlogpool.ilkname matchedilkpool.vataddress matches MCD_VAT address on chainlogpool.daiaddress matches MCD_DAI address on chainlogpool.adaiaddress matchesadaiaddresspool.stableDebtaddress matchesstableDebtaddresspool.variableDebtaddress matches variableDebt addresspool.kingvaluepool.hubaddress matcheshubaddress (code)pool.ilkname matchedilk(code)pool.vataddress matchesvataddress (code)pool.usdsJoinaddress matchesusdsJoin(code)pool.usdsaddress matchesusds(code)pool.daiJoinaddress matchesdaiJoin(code)pool.daiaddress matchesdaiaddress (code)pool.ausdsaddress matchesausdsaddress (code)pool.stableDebtaddress matchesstableDebtaddress (code)pool.variableDebtaddress matches variableDebt address (code)pool.kingvalue (code)plan.adaimatchesadai(code)plan.buffer(code)pool.hubaddress matcheshubaddress (code)pool.ilkname matchedilk(code)pool.vataddress matchesvataddress (code)pool.daiaddress matchesdaiaddress (code)pool.comptrolleraddress matchescomptrolleraddress (code)pool.comp()address matchescompaddress (code)pool.cDaiaddress matches cDai address (code)pool.king(code)plan.tacks(tack)returns 1 (code)cdai.interestRateModelmatchestack(code)plan.delegates(delegate)returns 1 (code)cdai.implementationmatchesdelegate(code)plan.cDaimatchescDaiaddress (code)plan.barb(code)pool.hubaddress matcheshubaddress (code)pool.ilkname matchedilk(code)pool.vataddress matchesvataddress (code)pool.daiaddress matchesdaiaddress (code)pool.vaultaddress matches givenvaultaddress (code)morphobefore but it will be used for next AaveV3USDS D3M (source)plan.operatoraddress to given operator address