Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions spell/star-spell-reviewer-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ This section outlines the review process and provides concrete action items for
#### Parameter Changes & Protocol Integration
- [ ] Star Protocol invariants are maintained after spell execution.
- [ ] All parameter changes use the appropriate helper functions IF available.
- [ ] Parameter changes match the Executive Sheet exactly.
- [ ] Parameter changes match the Executive Sheet or the corresponding Atlas edit exactly.
- [ ] Spell interacts correctly with existing protocol components.
- [ ] Proper error handling for all external interactions.

Expand All @@ -226,11 +226,15 @@ EXECUTED_TESTS_LOGS

#### Pre-Deployment checks
- [ ] Actions listed in the [Executive Sheet](https://docs.google.com/spreadsheets/d/1w_z5WpqxzwreCcaveB2Ye1PP5B8QAHDglzyxKHG3CHw/edit) for this Star match the spell scope.
- [ ] IF Executive Sheet is not yet ready at the time of review, reference [the corresponding Atlas edit weekly proposal](https://forum.sky.money/tag/atlas-edit-weekly-proposal)
- [ ] Every _Instruction text_ from the Executive Sheet is copied to the spell code as a comment.
- [ ] IF Executive Sheet is not yet ready at the time of review, reference [the corresponding Atlas edit weekly proposal](https://forum.sky.money/tag/atlas-edit-weekly-proposal)
- [ ] IF an instruction cannot be taken, it should have an explanation under the instruction prefixed with `// Note:`.
- [ ] IF an action in the spell doesn't have a relevant instruction, its necessity is explained in a comment prefixed with `// Note:`.
- [ ] All actions present in the spell code are present in the final Executive Sheet.
- [ ] IF Executive Sheet is not yet ready at the time of review, reference [the corresponding Atlas edit weekly proposal](https://forum.sky.money/tag/atlas-edit-weekly-proposal)
- [ ] All actions in the final Executive Sheet are present in the spell code.
- [ ] IF Executive Sheet is not yet ready at the time of review, reference [the corresponding Atlas edit weekly proposal](https://forum.sky.money/tag/atlas-edit-weekly-proposal)
- [ ] IF new commits were added after the initial review, the relevant checklist items have been re-verified.
- [ ] IF no blockers were found, post the completed "Development Stage" checklist stage with the explicit "Good to deploy" note on top.

Expand All @@ -245,8 +249,8 @@ EXECUTED_TESTS_LOGS
- [ ] Etherscan settings (optimizer, EVM version, license) match local ones.
- [ ] Every spell is deployed using standard `CREATE` (not `CREATE2`).
- [ ] Tests are updated to execute against the deployed spell(s).
- [ ] No test is skipped after deployment
- [ ] All tests are passing in CI at COMMIT_HASH.
- [ ] All tests listed above are not `skipped`.
- [ ] All tests are passing locally at COMMIT_HASH:

```
Expand All @@ -267,5 +271,4 @@ EXECUTED_TESTS_LOGS
- [ ] The spell address posted by the crafter in the `#govops` thread matches the spell evaluated above.
- [ ] Confirm the address (via a separate "reply to" message, restating the address to avoid edits).
- [ ] Ensure that no changes were made to the code since the spell was deployed and archived.
- [ ] Approve spell PR for merge via 'Approve' review option.
- [ ] IF no blockers were found, post the completed "Handover Stage" checklist stage with the explicit pull request approval.
- [ ] IF no blockers were found, post the completed "Handover Stage" checklist stage with the explicit pull request approval via 'Approve' review option.