feat: add octane review to core spell checklist - #78
Open
SidestreamStrongStrawberry wants to merge 5 commits into
Open
feat: add octane review to core spell checklist#78SidestreamStrongStrawberry wants to merge 5 commits into
SidestreamStrongStrawberry wants to merge 5 commits into
Conversation
amusingaxl
reviewed
Jul 30, 2026
Comment on lines
+209
to
+214
| * [ ] List every reported vulnerability and warning (split into separate items when one finding contains multiple different issues): | ||
| 1. Title [Octane URL] | ||
| * Link to the relevant code block: [GitHub permalink] | ||
| * Is this issue blocking spell deployment? | ||
| * Required reason (explain why it can be a problem or can't be): | ||
| * [ ] IF any blocking issue is found, raise it to the current spell signal group |
Contributor
There was a problem hiding this comment.
Given the high false positive ratio still present in Octane, this part could become very lengthy with the explanations of why a finding must be dismissed.
I'd suggest simply posting the URL to the report so the reviewers can check.
Optionally, the crafter could provide only the valid findings after discussing with the spell teams.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds octane review item into the core spell checklist.
Relevant links:
Here, instead of using contract event listener; (added the loop with interval and then fetch logs. To avoid websocket disconnection, error handling)