Mainnet Spell 2025-10-30 #497

0xLaz3r · 2025-10-28T21:03:31Z

Description

Contribution Checklist

PR title starts with (PE-<TICKET_NUMBER>)
Code approved
Tests approved
CI Tests pass

Checklist

coderabbitai · 2025-10-28T21:03:57Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 2025-10-30

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

src/DssSpell.sol

riccardopersiani · 2025-10-29T14:47:41Z

src/DssSpell.sol

    /// @param usr The USDS receiver.
    /// @param wad The USDS amount in wad precision (10 ** 18).
    function _transferUsds(address usr, uint256 wad) internal {
        // Note: Enforce whole units to avoid rounding errors


Suggested change

// Note: Enforce whole units to avoid rounding errors.

src/DssSpell.sol

src/DssSpell.t.base.sol

0xBasset · 2025-10-29T16:31:34Z

src/DssSpell.sol

+import { FlapperInit, KickerConfig } from "src/dependencies/dss-flappers/FlapperInit.sol";
+// Note: code matches https://github.com/sky-ecosystem/star-guard/blob/52239d716a89188b303f137fc43fb9288735ba2e/deploy/StarGuardInit.sol
+import { StarGuardInit, StarGuardConfig } from "src/dependencies/starguard/StarGuardInit.sol";
+// Note: code matches https://github.com/sky-ecosystem/endgame-toolkit/blob/fe734bea271e87c0b8e772d7adcccb46c4df1939/script/dependencies/treasury-funded-farms/TreasuryFundedFarmingInit.sol
+import { TreasuryFundedFarmingInit, FarmingInitParams } from "src/dependencies/lockstake/TreasuryFundedFarmingInit.sol";


nit: The reviewer checklist does mention single imports only (although I think this is cleaner).

I don't think this rule is applicable as checklist only mentions "Interfaces imported from dss-interfaces"
https://github.com/sky-ecosystem/pe-checklists/blob/393726a9adc7c7418fc7180482dfec8edc6b66fb/spell/spell-reviewer-mainnet-checklist.md?plain=1#L50

src/DssSpell.t.sol

src/DssSpell.sol

riccardopersiani · 2025-10-29T19:50:09Z

src/DssSpell.sol

+        StarGuardJobLike(STARGUARD_JOB).add(SPARK_STARGUARD);
+
+        // Add StarGuardJob to the Chainlog as CRON_STARGUARD_JOB
+        DssExecLib.setChangelogAddress("CRON_STARGUARD_JOB", STARGUARD_JOB);


Minor:
STARGUARD_JOB could be CRON_STARGUARD_JOB

Addressed already

riccardopersiani · 2025-10-30T09:43:22Z

src/DssSpell.sol

+    address internal constant REWARDS_LSSKY_SKY         = 0xB44C2Fb4181D7Cb06bdFf34A46FdFe4a259B40Fc;
+    address internal constant REWARDS_DIST_LSSKY_SKY    = 0x675671A8756dDb69F7254AFB030865388Ef699Ee;
+    address internal constant SPARK_STARGUARD           = 0x6605aa120fe8b656482903E7757BaBF56947E45E;
+    address internal constant CRON_STARGUARD_JOB             = 0xB18d211fA69422a9A848B790C5B4a3957F7Aa44E;


Suggested change

address internal constant CRON_STARGUARD_JOB = 0xB18d211fA69422a9A848B790C5B4a3957F7Aa44E;

address internal constant CRON_STARGUARD_JOB = 0xB18d211fA69422a9A848B790C5B4a3957F7Aa44E;

Align the new var

src/DssSpell.sol

src/DssSpell.t.sol

src/DssSpell.sol

SidestreamBurningBanana · 2025-10-30T15:46:38Z

src/dependencies/lockstake/TreasuryFundedFarmingInit.sol

Please move this file to its corresponding sub-directory, otherwise a diff is produced with the reviewed commit:

diff script/dependencies/treasury-funded-farms/TreasuryFundedFarmingInit.sol ../maker-mainnet-spells/src/dependencies/lockstake/TreasuryFundedFarmingInit.sol 18,19c18,19 < import {StakingRewardsInit, StakingRewardsInitParams} from "../StakingRewardsInit.sol"; < import {VestInit, VestCreateParams} from "../VestInit.sol"; --- > import {StakingRewardsInit, StakingRewardsInitParams} from "./StakingRewardsInit.sol"; > import {VestInit, VestCreateParams} from "./VestInit.sol"; 22c22 < } from "../VestedRewardsDistributionInit.sol"; --- > } from "./VestedRewardsDistributionInit.sol";

The proposed structure would include an additional subfolder treasury-funded-farms inside lockstake with this file

Also nit: please prefer naming the directories in accordance to their repository names (endgame-toolkit, star-guard)

0xBasset · 2025-10-30T16:42:13Z

src/DssSpell.t.sol

+
+        // Sanity checks
+        assertEq(rewards.rewardsDistribution(), address(dist), "testLsskySkyRewards/rewards-rewards-dist-mismatch");
+        assertEq(rewards.stakingToken(), lssky, "testLsskySkyRewards/rewards-staking-token-mismatch");


I think we should revert with the error messages.

0xLaz3r added 18 commits October 28, 2025 13:31

chore: 🔥 clean up previous spell

08b7b97

chore: 🔥 clean up dependencies

bee3a49

feat: ✨ init kicker

1427fb6

test: ✅ fix kicker test

5d77a33

feat: ✨ set SBE values

2c670cf

feat: ✨ init lssky->sky farm

8bf67a9

feat: ✨ update rate setter

197ffe1

feat: ✨ add payments

f6f224c

feat: ✨ add Spark and Grove spells

8afe981

feat: ✨ init StarGuard

870cd43

refactor: 🔧 update system config and fix test

b425647

docs: 📝 add forum/poll/atlas links

7f2ce03

fix: ✅ updated SKY vest in config

02592d9

test: ✅ update splitter tests

85fa307

test: ✅ add specific test for kicker initialization

fde296e

test: ✅ enable testVestSky

aba630a

test: 🐛 set correct vestId in testVestSky

682c393

test: ✅ fix testVestSky

58c794c

0xLaz3r added 5 commits October 28, 2025 23:17

docs: 📝 add exec doc url and hash

ca030d3

fix: 🐛 update wrong instructions

40b5a2c

test: ✅ add happy path for lssky->sky farm

01f1ee1

test: ✅ add happy path for rate setter

743713f

test: ✅ add happy path for StarGuard spell execution

b1aa9a3

0xLaz3r requested review from SidestreamBurningBanana, SidestreamFrostyFig and riccardopersiani October 28, 2025 23:59

0xLaz3r self-assigned this Oct 29, 2025

riccardopersiani reviewed Oct 29, 2025

View reviewed changes

src/DssSpell.sol Outdated Show resolved Hide resolved

SidestreamFrostyFig reviewed Oct 29, 2025

View reviewed changes

src/DssSpell.sol Show resolved Hide resolved

src/DssSpell.sol Outdated Show resolved Hide resolved

src/DssSpell.sol Outdated Show resolved Hide resolved

src/DssSpell.sol Outdated Show resolved Hide resolved

0xLaz3r added 3 commits October 29, 2025 13:56

docs: ✏️ update chainlog bump comment

7d7761f

docs: ✏️ rename STAR_GUARD to STARGUARD

570e3ea

fix: ✏️ rename <STAR>_PROXY to <STAR>_SUBPROXY

e3a78a4

riccardopersiani reviewed Oct 29, 2025

View reviewed changes

style: ✏️ add period at the end of instruction

62a9943

SidestreamBurningBanana reviewed Oct 29, 2025

View reviewed changes

src/DssSpell.t.base.sol Outdated Show resolved Hide resolved

src/DssSpell.t.base.sol Outdated Show resolved Hide resolved

src/DssSpell.t.base.sol Outdated Show resolved Hide resolved

0xBasset reviewed Oct 29, 2025

View reviewed changes

SidestreamFrostyFig reviewed Oct 29, 2025

View reviewed changes

src/DssSpell.t.sol Show resolved Hide resolved

src/DssSpell.t.sol Show resolved Hide resolved

src/DssSpell.t.sol Show resolved Hide resolved

0xLaz3r added 5 commits October 29, 2025 18:53

revert: ⏪ revert back changes in testSplitter scenario

5b300ed

fix: 📝 fix MCD_KICK instruction

1f761cd

test: ✅ add one-time 500 million SKY transfer to PauseProxy in tests

afa0eb9

test: ✅ enable testLockstakeIlkIntegration test

527fff3

test: ✅ add test for StarGuard's drop() function

640fdcc

SidestreamBurningBanana reviewed Oct 30, 2025

View reviewed changes

src/DssSpell.sol Outdated Show resolved Hide resolved

fix: ✏️ rename STARGUARD_JOB to CRON_STARGUARD_JOB

dcd8f78

riccardopersiani reviewed Oct 30, 2025

View reviewed changes

0xLaz3r added 2 commits October 30, 2025 11:15

style: 🎨 align CRON_STARGUARD_JOB variable

b1a4d3d

test: ✅ add test for old CRON_FLAP_JOB removal

483543f

SidestreamBurningBanana reviewed Oct 30, 2025

View reviewed changes

src/DssSpell.sol Show resolved Hide resolved

0xLaz3r added 2 commits October 30, 2025 13:17

refactor: 💡 correct instructions order

cd6e0c8

style: 🎨 delete extra "/" in comment

fbcbf90

SidestreamFrostyFig reviewed Oct 30, 2025

View reviewed changes

src/DssSpell.t.sol Show resolved Hide resolved

src/DssSpell.t.sol Show resolved Hide resolved

test: ✅ add happy path for new CRON_FLAP_JOB

555de1b

SidestreamBurningBanana reviewed Oct 30, 2025

View reviewed changes

src/DssSpell.t.sol Outdated Show resolved Hide resolved

src/DssSpell.t.sol Outdated Show resolved Hide resolved

src/DssSpell.sol Show resolved Hide resolved

SidestreamBurningBanana reviewed Oct 30, 2025

View reviewed changes

0xLaz3r added 3 commits October 30, 2025 16:50

test: ✅ add happy path for CRON_STARGUARD_JOB

852de92

test: ♻️ use assertTrue/assertFalse instead of assertEq when possible

042c051

test: ✅ add distJob and interval test

567294b

0xBasset reviewed Oct 30, 2025

View reviewed changes

	address internal constant CRON_STARGUARD_JOB = 0xB18d211fA69422a9A848B790C5B4a3957F7Aa44E;
	address internal constant CRON_STARGUARD_JOB = 0xB18d211fA69422a9A848B790C5B4a3957F7Aa44E;

Mainnet Spell 2025-10-30 #497

Are you sure you want to change the base?

Mainnet Spell 2025-10-30 #497

Conversation

0xLaz3r commented Oct 28, 2025

Description

Contribution Checklist

Checklist

Uh oh!

coderabbitai bot commented Oct 28, 2025

Review skipped

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants