-
Notifications
You must be signed in to change notification settings - Fork 59
Mainnet spell 2025-11-17 #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Good to deploy Mainnet Executive Spell Review ChecklistRepo: https://github.com/sky-ecosystem/spells-mainnet Development Stage
Pre-Deployment Stage
|
|
Good to deploy: Mainnet Executive Spell Review ChecklistRepo: https://github.com/sky-ecosystem/spells-mainnet Development Stage
Pre-Deployment Stage
|
|
|
Good to handover Deployed Stage
|
|
Good to handover: Deployed Stage
|
SidestreamBurningBanana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handover and Merge Stage
- Check that the spell address posted by the crafter in
new-spellsis correct - Confirm the address in the
new-spellschannel (via a separate "reply to" message, restating the address to avoid edits)- Wait until responsible governance facilitator confirms handover in
new-spells
- Wait until responsible governance facilitator confirms handover in
- Ensure that no changes were made to the code since the spell was deployed and archived
- Approve spell PR for merge via 'Approve' review option
oddaf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handover and Merge Stage
- Check that the spell address posted by the crafter in
new-spellsis correct - Confirm the address in the
new-spellschannel (via a separate "reply to" message, restating the address to avoid edits)- Wait until responsible governance facilitator confirms handover in
new-spells
- Wait until responsible governance facilitator confirms handover in
- Ensure that no changes were made to the code since the spell was deployed and archived
- Approve spell PR for merge via 'Approve' review option
Description
This spell contents are based on Executive Sheet
Contribution Checklist
(PE-<TICKET_NUMBER>)Checklist
officeHoursmodifier override30 daysunless otherwise specified)ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploymainnetcontract on etherscanmake archive-spellormake date="YYYY-MM-DD" archive-spellto make an archive directory and copyDssSpell.sol,DssSpell.t.sol,DssSpell.t.base.sol, andDssSpellCollateralOnboarding.solsquash and mergethis PR