UI & Fix: Upgrade ClaimUsername dropdowns with Shadcn Select and resolve Vite config lint error - #132
Merged
Merged
Conversation
|
Someone is attempting to deploy a commit to the Sky Ruler's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR focuses heavily on visual consistency and modern aesthetics by replacing the native HTML
<select>dropdowns on theClaimUsernamepage with customshadcn-uiSelect components, bringing them perfectly in line with the app's overall glassmorphic design system.Additionally, this PR addresses a failing GitHub Actions lint check caused by an unresolved
__dirnamevariable in the Vite configuration.Key Changes
UI & Design Upgrades
@base-ui/react/selectviashadcn-uiand generated ajsconfig.jsonto properly alias imports.h-8), enabling the dropdown triggers to automatically inherit the dynamicpy-3padding. This ensures they perfectly vertically align and match the height of the standard text inputs.SelectContentdropdown container with a translucent blur effect (backdrop-blur-xl,bg-[#0f111a]/70,border-white/10) for a sleek, modern feel.300pxand implemented custom, thin translucent scrollbars.SelectItempadding and font size (text-[13px]) to reduce bulkiness.SelectLabelgroup headers to be small (text-[10px]), bold, uppercase, and wide-tracked for clear visual separation.focus:bg-accent/80 focus:text-white) that seamlessly blends with the glass background.Linting & Configuration Fixes
fileURLToPathfromurlanddirnamefrompathinclient/vite.config.js.__dirnameusingimport.meta.urlto resolve ano-undefESLint error. This ensures the@alias (used for thesrcdirectory) correctly resolves the absolute path in modern ES module environments.Testing
npm run lintnow passes successfully on the client directory in GitHub Actions.@alias flawlessly.