Skip to content

Rename runtimeParameters to Parameters #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

alexgeorgousis
Copy link
Contributor

@alexgeorgousis alexgeorgousis commented Apr 16, 2025

Closes #612

Tasks

  • Update code refs
  • Update doc refs
  • Test

@alexgeorgousis alexgeorgousis force-pushed the run-params branch 10 times, most recently from d94368a to 5576b64 Compare April 17, 2025 09:27
@alexgeorgousis
Copy link
Contributor Author

alexgeorgousis commented Apr 22, 2025

RC controller decoupled test failing on CI:

runconfiguration_controller_decoupled_test.go:176

  [FAILED] Expected success, but got an error:

      <*errors.StatusError | 0xc0012da320>: 
      Operation cannot be fulfilled on runconfigurations.pipelines.kubeflow.org "2le2ci": the object has been modified; please apply your changes to the latest version and try again
      {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "Operation cannot be fulfilled on runconfigurations.pipelines.kubeflow.org \"2le2ci\": the object has been modified; please apply your changes to the latest version and try again",
              Reason: "Conflict",
              Details: {
                  Name: "2le2ci",
                  Group: "pipelines.kubeflow.org",
                  Kind: "runconfigurations",
                  UID: "",
                  Causes: nil,
                  RetryAfterSeconds: 0,
              },
              Code: 409,
          },
      }
  In [It] at: /home/jenkins/agent/workspace/mlops/kfp-operator/_pr-builder/kfp-operator/controllers/pipelines/runconfiguration_controller_decoupled_test.go:200 @ 04/18/25 09:49:57.185


This happens because the RC is mysteriously changed between the Create and the Update that occurs in that test. This is something I've noticed when installing the latest (master) version of the operator in K8s clusters, though I can't reproduce it reliably.

It's strange though, because CI tests (including this decoupled test) must have passed on all PRs before being merged, so why is this happening now?

@alexgeorgousis alexgeorgousis force-pushed the run-params branch 2 times, most recently from 709f591 to e8aadda Compare April 22, 2025 12:07
@alexgeorgousis
Copy link
Contributor Author

RC controller decoupled test failing on CI:

runconfiguration_controller_decoupled_test.go:176

  [FAILED] Expected success, but got an error:

      <*errors.StatusError | 0xc0012da320>: 
      Operation cannot be fulfilled on runconfigurations.pipelines.kubeflow.org "2le2ci": the object has been modified; please apply your changes to the latest version and try again
      {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "Operation cannot be fulfilled on runconfigurations.pipelines.kubeflow.org \"2le2ci\": the object has been modified; please apply your changes to the latest version and try again",
              Reason: "Conflict",
              Details: {
                  Name: "2le2ci",
                  Group: "pipelines.kubeflow.org",
                  Kind: "runconfigurations",
                  UID: "",
                  Causes: nil,
                  RetryAfterSeconds: 0,
              },
              Code: 409,
          },
      }
  In [It] at: /home/jenkins/agent/workspace/mlops/kfp-operator/_pr-builder/kfp-operator/controllers/pipelines/runconfiguration_controller_decoupled_test.go:200 @ 04/18/25 09:49:57.185

This happens because the RC is mysteriously changed between the Create and the Update that occurs in that test. This is something I've noticed when installing the latest (master) version of the operator in K8s clusters, though I can't reproduce it reliably.

It's strange though, because CI tests (including this decoupled test) must have passed on all PRs before being merged, so why is this happening now?

This bug was tracked by #625 and has been resolved in #622

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename runtimeParameters to parameters
1 participant