chore(lint): de-deprecate httprate.LimitByIP + gofmt addrresolver (unblock CI)#3509
Merged
0pcom merged 1 commit intoJul 17, 2026
Merged
Conversation
golangci-lint on ./... (v2.12.2, after the httprate dep bump) surfaced two pre-existing develop lint errors that block every PR's CI: - pkg/uptime-tracker/api/api.go: httprate.LimitByIP is deprecated (SA1019). Replace with the explicit non-deprecated LimitBy + a local keyByRemoteAddr key func that inlines the old KeyByIP behavior (per-r.RemoteAddr, IPv6 /64). Identical runtime behavior; just states the trust model explicitly. - pkg/transport/network/addrresolver/client.go: gofmt (a stray double blank line). gofmt -w.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golangci-lint on
./...(v2.12.2, after the recent httprate dependency bump) surfaces two pre-existing develop lint errors that currently fail thelinux/darwin/windowsjobs on every open PR:Fixes:
httprate.LimitByIP(...)with the explicithttprate.LimitBy(..., keyByRemoteAddr)+ a localkeyByRemoteAddrkey func inlining the oldKeyByIPbehavior (per-r.RemoteAddr, IPv6 canonicalized to /64). Identical runtime behavior — the deprecation only asks callers to state the trust model explicitly.gofmt -w(a stray double blank line).Doc/format + behavior-preserving only.
go build ./..., gofmt, and golangci-lint clean. Unblocks #3507, #3508, and other open PRs.