Stop visual-test scripts leaving empty folders and popping Finder#1144
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 46d66f2. Configure here.
visual-test-start.sh pre-creates the timestamped screenshot dir before any capture, and visual-test-stop.sh then ran open on it unconditionally. Runs that captured nothing left an empty zero-KB folder and popped a Finder window every time. Stop only opens the folder when it actually contains screenshots and removes it otherwise. Start prunes leftover empty dirs from prior runs while preserving the active run recorded in the state file.
46d66f2 to
896e942
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Visual-test runs that capture no screenshots no longer leave empty timestamped folders behind or open Finder on an empty directory. This keeps repeated local visual-test runs quiet while preserving screenshot folders when captures actually exist.
What changed
visual-test-stop.shopens the screenshot folder only when it contains captured files..playwright-mcp/visual-test/.visual-test-start.shprunes leftover empty timestamped directories before a new run starts..playwright-mcp/visual-test-state.envwhen that Radar process is still alive, so relaunching with--skip-buildcannot delete the active capture target.Testing
bash -n scripts/visual-test-start.shbash -n scripts/visual-test-stop.shgit diff --check