Stop logging routine topology broadcasts#1148
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid flooding Radar server logs with a success message on every debounced topology update. Topology broadcasts continue unchanged and remain observable through the existing SSE broadcast performance counter.
Testing
make testmake buildNote
Low Risk
Logging-only change with no behavior change to SSE delivery or topology build logic.
Overview
Removes the
log.Printfthat ran on every successful debounced topology broadcast inbroadcastTopologyUpdate, which was flooding Radar server logs during normal operation.SSE topology broadcasts are unchanged — clients still receive updates on the same debounce schedule.
perfstats.IncSSEBroadcast()remains so broadcast volume stays visible via diagnostics/performance counters instead of log lines.Reviewed by Cursor Bugbot for commit 2a7e476. Bugbot is set up for automated code reviews on this repo. Configure here.