-
Notifications
You must be signed in to change notification settings - Fork 616
[UX] update docs and minors for dashboard #5287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
We need to show the dashboard URL when running |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User story: I tried to type sky dashboard
and sky ui
but failed. We should discuss adding one (open().
Hi @Michaelvll @concretevitamin @romilbhardwaj, comments addressed, PTAL again. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DanielZhangQD! It looks mostly good to me. Just that we can improve the screenshot for the dashboard.
Hi @Michaelvll Screenshots have been updated, PTAL again. Thanks! |
sky clusters
sky api info
Tested (run the relevant ones):
bash format.sh
/smoke-test
(CI) orpytest tests/test_smoke.py
(local)/smoke-test -k test_name
(CI) orpytest tests/test_smoke.py::test_name
(local)/quicktest-core
(CI) orpytest tests/smoke_tests/test_backward_compat.py
(local)