Skip to content

[UX] update docs and minors for dashboard #5287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

DanielZhangQD
Copy link
Collaborator

@DanielZhangQD DanielZhangQD commented Apr 19, 2025

  • Update docs for dashboard
  • Fix hover effect for sky clusters
  • Add dashboard URL to the output of sky api info
  • Improve dashboard for mobile case
  • Update favicon
  • Do not fetch logs when the managed job is recovering

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@DanielZhangQD DanielZhangQD marked this pull request as ready for review April 21, 2025 01:41
@Michaelvll Michaelvll requested review from romilbhardwaj and removed request for Michaelvll April 21, 2025 18:37
@Michaelvll
Copy link
Collaborator

We need to show the dashboard URL when running sky api info or sky api start when a API server already exists.

@DanielZhangQD
Copy link
Collaborator Author

We need to show the dashboard URL when running sky api info or sky api start when a API server already exists.

sky api info already supports this, and I will check sky api start.

Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User story: I tried to type sky dashboard and sky ui but failed. We should discuss adding one (open().

@DanielZhangQD
Copy link
Collaborator Author

Hi @Michaelvll @concretevitamin @romilbhardwaj, comments addressed, PTAL again. Thanks!

@DanielZhangQD
Copy link
Collaborator Author

Here is the job detail page in the recovering status:
image

Please note that if we are already in this page when the job is running, and when it changes to recovering status, we need to click the refresh button on the heading bar to trigger the waiting for the job to recover hint because refreshing the log only will not re-fetch the job detail data to get the latest job status.

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DanielZhangQD! It looks mostly good to me. Just that we can improve the screenshot for the dashboard.

@DanielZhangQD
Copy link
Collaborator Author

Hi @Michaelvll Screenshots have been updated, PTAL again. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants