support python 3.12 and 3.13 #5304
Conversation
sky/provision/docker_utils.py
Outdated
There was a problem hiding this comment.
Starting in Python 3.12, there is a warning `.../sky/provision/docker_utils.py:333: SyntaxWarning: invalid escape sequence '&'.
This should be what's intended.
|
@romilbhardwaj do you want this in 0.9.0? |
cg505
force-pushed
the
py-version-upgrade
branch
from
0de0d37 to
d0e3ad0
Compare
Michaelvll
left a comment
Michaelvll
left a comment
There was a problem hiding this comment.
Thanks @cg505! Can we run some smoke tests that test custom docker images?
sky/setup_files/dependencies.py
Outdated
| if sys.version_info >= (3, 12): | ||
| # The version of ray we use does not work with >= 3.12, so avoid clouds | ||
| # that require ray. | ||
| clouds_for_all -= {'ibm', 'docker', 'scp'} |
There was a problem hiding this comment.
Can we keep this at the top as a constant?
|
PYTHON_VERSION=3.11 /smoke-test |
|
PYTHON_VERSION=3.12 /smoke-test |
|
PYTHON_VERSION=3.13 /smoke-test |
|
PYTHON_VERSION=3.7 /smoke-test |
|
don't merge, need to look at smoke test failures |
|
heyo just wanted to check if this is still in the works? |
cg505
force-pushed
the
py-version-upgrade
branch
from
c50e173 to
1a06c0c
Compare
|
PYTHON_VERSION=3.7 /smoke-test - didn't work, |
|
PYTHON_VERSION=3.11 /smoke-test |
4 participants
Fix #3680.
The version of ray we are using does not support 3.12+, but on the client side we only need ray for the old provisioner. Exclude these clouds from
skypilot[all]as well as vast due to a dependency issue (vast-ai/vast-sdk#6).Once you do this, everything seems to work okay. We should smoke test on the new Python versions though.
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)