[GKE] Avoid erroring out for unknown instance type when GKE autoscaler is used

[Michaelvll]

A user encountered an issue when a GKE has a node pool with instance type that does not appear in the GCP catalog, with the autoscaler: gke set in config. The error only happens when scaling from 0 (to confirm?).

ValueError: No instance type c3d-highmem-16-lssd found.

We should add the following instance type: c3d, c4, c4a, c4d, n4 to catalog as well

Tested (run the relevant ones):

• Code formatting: install pre-commit (auto-check on commit) or bash format.sh
• Any manual or new tests for this PR (please specify below)
  • GKE cluster with a c3d-highmem-16-lssd node pool. Set the autoscaler: gke, and run sky launch --cpus 10, it outputs the optimizer table correctly.
• All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
• Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
• Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

[gemini-code-assist]

Summary of Changes

Hello @Michaelvll, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the GKE autoscaler by introducing error handling for unrecognized instance types during node pool compatibility checks. Previously, encountering an instance type not present in the GCP catalog would cause the autoscaler to error. The updated logic now gracefully handles such cases by logging the issue and allowing the check to pass, ensuring continuous operation for GKE clusters utilizing newer or less common machine types.

Highlights

• GKE Autoscaler Resilience: Implemented error handling within the GKE autoscaler's node pool fit check to gracefully manage unknown instance types, preventing the autoscaler from crashing.
• Instance Type Recognition: The clouds.GCP.get_vcpus_mem_from_instance_type call is now wrapped in a try-except ValueError block; if an instance type is unrecognized, an error is logged, and the check is bypassed, assuming the node pool can satisfy the request.
• New Instance Types: The pull request description notes that new instance types like c3d, c4, c4a, c4d, n4 should be added to the GCP catalog to prevent future issues with these specific types.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request makes the GKE autoscaler check more robust by handling unknown instance types gracefully. Instead of erroring out, it now catches ValueError when an instance type is not found in the catalog, logs the event, and optimistically assumes the instance can be provisioned. This is a good improvement for forward compatibility with new GKE machine types. My only suggestion is to change the log level from error to warning for this case, as it's a handled condition rather than a failure.