[Docs] Add hint for GCP private registry #8377
Conversation
Summary of ChangesHello @Michaelvll, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the documentation for Kubernetes getting started, focusing on improving the user experience when configuring private registries on Google Cloud Platform. It introduces a clear hint that guides users in identifying the correct registry server based on their image's URL, thereby streamlining the setup process and reducing potential errors. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| If you are not sure which registry to use, check the base of your | ||
| image URL. For example, if your image URL looks like ``gcr.io/my-gcp-project-id/my-registry-repository/my-image-name:latest``, | ||
| you should use ``gcr.io`` as the registry server. If your image URL looks like ``us-docker.pkg.dev/my-gcp-project-id/my-registry-repository/my-image-name:latest``, | ||
| you should use ``us-docker.pkg.dev`` as the registry server. |
There was a problem hiding this comment.
This is a great addition! To make it even clearer for users, I suggest a slight rephrasing to be more direct and use consistent terminology.
| If you are not sure which registry to use, check the base of your | |
| image URL. For example, if your image URL looks like ``gcr.io/my-gcp-project-id/my-registry-repository/my-image-name:latest``, | |
| you should use ``gcr.io`` as the registry server. If your image URL looks like ``us-docker.pkg.dev/my-gcp-project-id/my-registry-repository/my-image-name:latest``, | |
| you should use ``us-docker.pkg.dev`` as the registry server. | |
| If you are not sure which registry server to use, you can find it from your | |
| image URL. For example, if your image URL is ``gcr.io/my-gcp-project-id/my-registry-repository/my-image-name:latest``, | |
| the registry server is ``gcr.io``. If your image URL is ``us-docker.pkg.dev/my-gcp-project-id/my-registry-repository/my-image-name:latest``, | |
| the registry server is ``us-docker.pkg.dev``. |
|
/build-docs |
|
✅ ReadTheDocs build triggered for branch The documentation will be available at: https://docs.skypilot.co/en/private-registry-docs/ |
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)