[Core] Set CWD to avoid an issue where a user image has WORKDIR sets to site-packages

[Michaelvll]

Tested (run the relevant ones):

• Code formatting: install pre-commit (auto-check on commit) or bash format.sh
• Any manual or new tests for this PR (please specify below)
• All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
• Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
• Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

[gemini-code-assist]

Summary of Changes

Hello @Michaelvll, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the reliability of the SkyPilot runtime by implementing a more robust command execution strategy. It introduces a mechanism to explicitly manage the execution environment for Python and uv commands, specifically by unsetting the PYTHONPATH and ensuring commands run from the user's home directory. This prevents potential conflicts and issues that could arise from user-defined Docker image configurations, particularly when the WORKDIR is set to a Python site-packages directory, thereby improving overall system stability.

Highlights

• Runtime Stability Improvement: Introduced a new environment prefix, SKY_UNSET_PYTHONPATH_AND_SET_CWD, which combines unsetting the PYTHONPATH and setting the current working directory to $HOME.
• Issue Mitigation: This change directly addresses an issue where user-provided Docker images with WORKDIR set to a site-packages directory could interfere with the SkyPilot runtime, ensuring commands execute in a more controlled environment.
• Command Execution Update: Updated SKY_PYTHON_CMD and SKY_UV_CMD to utilize the new SKY_UNSET_PYTHONPATH_AND_SET_CWD prefix, enhancing the robustness of Python and uv command executions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue where a user's container image with a WORKDIR set to site-packages could interfere with SkyPilot's runtime. The fix is to prefix commands with env -C $HOME to ensure they run in the user's home directory. The change is correct and well-commented. I've provided a suggestion to use a more generic constant name for better maintainability and also raised a point about potentially applying a similar fix for Slurm environments.