[Slurm] Add option to specify workdir and tmpdir

[kevinmingtarja]

In one of the Slurm clusters we're testing on, $HOME is not on an NFS, which breaks one simplifying assumption we had:

ubuntu@ml-16-head-001:~$ pwd
/home_local/ubuntu                                                                           
ubuntu@ml-16-head-001:~$ df -T .
Filesystem     Type 1K-blocks     Used Available Use% Mounted on
/dev/vda1      ext4 202051056 18871872 183162800  10% /

This PR adds a config option to be able to override the "workdir" and "tmpdir" that we use, which defaults to $HOME and /tmp respectively.

TODO: Support variable expansion as the config value, i.e. /home/$USER

Tested (run the relevant ones):

• Code formatting: install pre-commit (auto-check on commit) or bash format.sh
• Any manual or new tests for this PR (please specify below)
• All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
• Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
• Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

[gemini-code-assist]

Summary of Changes

Hello @kevinmingtarja, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances SkyPilot's compatibility with diverse Slurm cluster environments by introducing configurable working and temporary directories. This allows users to override the default paths, which is particularly useful in setups where the home directory is not shared across nodes, thus preventing potential operational issues and broadening the range of supported Slurm configurations.

Highlights

• Configurable Work and Temp Directories: Introduced workdir and tmpdir options for Slurm clusters, allowing users to specify custom paths for SkyPilot's operations. This addresses scenarios where the default $HOME directory is not NFS-mounted.
• Default Path Handling: The new workdir defaults to ~ (user's home directory) and tmpdir defaults to /tmp if not explicitly configured, maintaining backward compatibility.
• Configuration Integration: These new options are integrated into the SkyPilot configuration system, accessible via skypilot_config.get_effective_region_config for Slurm clusters.
• Path Utility Updates: Internal utility functions like _sky_cluster_home_dir, _sbatch_provision_script_path, and _skypilot_runtime_dir have been updated to utilize the configurable workdir and tmpdir.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request successfully introduces configurable "workdir" and "tmpdir" options for Slurm clusters, addressing the issue of $HOME not always being on an NFS mount. The changes are well-implemented, utilizing skypilot_config for configuration retrieval and os.path.join for robust path construction. The schema updates correctly reflect these new configuration options.

[gemini-code-assist]

This logger.info statement is useful for debugging during development but might be too verbose for production logs. Consider changing it to logger.debug to keep the default log level cleaner, or remove it once the feature is stable.

Suggested change

	logger.info(f'workdir: {workdir}, tmpdir: {tmpdir}')
	logger.debug(f'workdir: {workdir}, tmpdir: {tmpdir}')

[kevinmingtarja]

Removing.