[Test]Add controller logs for tail test #8383
Conversation
Summary of ChangesHello @zpoint, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the debugging workflow for failed tests by automating the collection of controller logs for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a helpful debugging feature by fetching controller logs for failed tests. The implementation is sound, but I have a couple of suggestions to improve efficiency and adhere to best practices in shell scripting and Python's subprocess usage.
| script_proc = subprocess.Popen( | ||
| f'bash {script_path}', | ||
| stdout=subprocess_out, | ||
| stderr=subprocess.STDOUT, | ||
| shell=True, | ||
| executable='/bin/bash', | ||
| env=env_dict, | ||
| ) |
There was a problem hiding this comment.
Using shell=True with subprocess.Popen can be a security risk if parts of the command are from external input. While it's safe in this context, it's best practice to avoid it. You can achieve the same result more safely and cleanly by passing the command and arguments as a list and omitting shell=True.
script_proc = subprocess.Popen(
['/bin/bash', script_path],
stdout=subprocess_out,
stderr=subprocess.STDOUT,
env=env_dict,
)
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/smoke-test --kubernetes -k test_managed_jobs_basic |
|
/smoke-test --kubernetes -k test_managed_jobs_basic |
1 participant
For failure tests, add controller logs at the end of the test for easier debugging.
work here: https://buildkite.com/skypilot-1/smoke-tests/builds/6777#019b45de-3d38-404f-850f-b7a6470dc6e1
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)