[UX] dashboard controller logs accessible earlier

[lucamanolache]

Needs more testing, but should show the controller log in the dashboard, instead of the "Waiting for the job controller process to start, please refresh after a while" message.

Tested (run the relevant ones):

• Code formatting: install pre-commit (auto-check on commit) or bash format.sh
• Any manual or new tests for this PR (please specify below)
• All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
• Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
• Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

[gemini-code-assist]

Summary of Changes

Hello @lucamanolache, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the user experience by making controller logs accessible earlier in the job lifecycle. It introduces the ability to retrieve logs using a controller's UUID, alongside existing integer job IDs, and refines the dashboard's understanding of controller status. These changes provide users with more immediate insights into job initialization and pending states, facilitating quicker debugging and monitoring.

Highlights

• Enhanced Controller Log Access: The system now allows earlier access to controller logs, improving visibility into job startup and pending states.
• Flexible Job ID Handling: The job_id parameter in log-related functions now accepts both integer job IDs and string UUIDs, enabling more granular log retrieval for controller processes.
• Dashboard UI Improvement: The dashboard's logic for determining if a controller is running has been updated to consider controller_pid and schedule_state, ensuring logs are displayed even when jobs are in a PENDING status.
• New Controller Log Streaming: Introduced dedicated functions (find_controller_pid_by_uuid, stream_controller_logs) to efficiently locate and stream logs specifically for controller processes.
• Type Hint Modernization: Updated type hints across the codebase to Optional[Union[int, str]] for job_id parameters, reflecting the expanded functionality.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a useful feature to access controller logs earlier in the job lifecycle by using a UUID-based string identifier for jobs before they are assigned a numeric ID. The changes are well-distributed across the backend, CLI, and dashboard to support this new functionality. The logic for handling the dual job_id types (int and string) is consistently implemented. However, I found a critical issue in the log streaming logic that could lead to a crash.

[gemini-code-assist]

The pid variable can be None if find_controller_pid_by_uuid does not find a running process. In this case, psutil.pid_exists(pid) will raise a TypeError because it expects an integer. This will cause the log streaming to crash. You should handle the case where pid is None.

Suggested change

	if not psutil.pid_exists(pid):
	if pid is None or not psutil.pid_exists(pid):

[lucamanolache]

oops committed my other changes. only should be changes in [jobs].tsx will cherrypick later