Refactor local iterator handling in txn.rs, removing duplicate logic#177
Open
mehrdad3301 wants to merge 1 commit into
Open
Refactor local iterator handling in txn.rs, removing duplicate logic#177mehrdad3301 wants to merge 1 commit into
mehrdad3301 wants to merge 1 commit into
Conversation
Removed unused entry assignment and streamlined local iterator usage.
There was a problem hiding this comment.
Pull request overview
This PR simplifies transaction-range scanning by removing duplicate “advance local iterator” logic and relying on the StorageIterator::next() implementation for TxnLocalIterator to initialize its first item.
Changes:
- Removed manual
entry_to_item(iter.next())+ assignment inTransaction::scan. - Primed the local iterator via
local_iter.next()?before constructing the merged iterator.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unused entry assignment and streamlined local iterator usage.