fix(picker): implement W3C listbox ARIA pattern for toolbar pickers#4807
Open
manichandra wants to merge 1 commit into
Open
fix(picker): implement W3C listbox ARIA pattern for toolbar pickers#4807manichandra wants to merge 1 commit into
manichandra wants to merge 1 commit into
Conversation
- Add role="listbox" to picker options container - Add role="option" and aria-selected to picker items (replaces role="button") - Add aria-haspopup="listbox" and aria-label to picker label button - Manage aria-selected state transitions in selectItem() - Add ArrowDown/ArrowUp keyboard navigation from label button - Add ArrowDown/ArrowUp keyboard navigation between option items - Add aria-label from option text content to each item Fixes slab#4439 - Screen readers can now announce the picker as a listbox, identify each item as a selectable option, and users can navigate options with arrow keys per the ARIA combobox/listbox pattern.
manichandra
force-pushed
the
fix/picker-aria-listbox-keyboard-nav
branch
from
6e799fc to
c13f539
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4439 - Screen readers can now announce the picker as a listbox, identify each item as a selectable option, and users can navigate options with arrow keys per the ARIA combobox/listbox pattern.