Do not add a ZK store reader per log #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have seen some stability issues with large Astra clusters around large searches. We found that most of this instability was caused by ZK timeouts because we were adding a reader per log per search, which is a write operation. Turns out the listener is not necessary.
This PR removes the listener add (i.e. removes the expensive write operations) and moves the
listSynccache call to the per-search level instead of per-log. The thought here is that we do not need to know about a new redaction in the middle of a search, especially since redactions are added very infrequently.Requirements