Skip to content

Protect against impossible metadata store configurations#1647

Open
kyle-sammons wants to merge 1 commit into
masterfrom
ksammons-prevent-impsosible-configuration
Open

Protect against impossible metadata store configurations#1647
kyle-sammons wants to merge 1 commit into
masterfrom
ksammons-prevent-impsosible-configuration

Conversation

@kyle-sammons
Copy link
Copy Markdown
Collaborator

Summary

We recently ran into a situation where we accidentally had ASTRA_ETCD_ENABLED: false, but also had ASTRA_DATASET_METADATA_STORE_MODE: ETCD_CREATES. This was resulting in NPEs being thrown when the recovery nodes went to rollover a chunk. While the fix in our configuration was easy, it went undetected for longer than it should have. This PR fixes that and prevents the node from booting if an impossible metadata store configuration occurs. We already do similar checks in other places, this was just a gap in our logic

Requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants