Protect against impossible metadata store configurations#1647
Open
kyle-sammons wants to merge 1 commit into
Open
Protect against impossible metadata store configurations#1647kyle-sammons wants to merge 1 commit into
kyle-sammons wants to merge 1 commit into
Conversation
shellywu815
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We recently ran into a situation where we accidentally had
ASTRA_ETCD_ENABLED: false, but also hadASTRA_DATASET_METADATA_STORE_MODE: ETCD_CREATES. This was resulting in NPEs being thrown when the recovery nodes went to rollover a chunk. While the fix in our configuration was easy, it went undetected for longer than it should have. This PR fixes that and prevents the node from booting if an impossible metadata store configuration occurs. We already do similar checks in other places, this was just a gap in our logicRequirements