slack-19.0: pre-backport v23 vtorc PR vitessio/vitess#17985

[timvaillancourt]

Description

Pre-backport upstream v23 PR vitessio#17985 in order to provide some test results to upstream

Related Issue(s)

vitessio#17985

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[ejortegau]

I have seen single shard keyspaces referred to as shard 0. Should that be included here?

[timvaillancourt]

@ejortegau technically 0 is a single shard in the middle of the keyspace. And - is actually referring to the entire shard range of the keyspace

So, no I believe this logic is correct as-is. Considering 0 to be a whole keyspace has consequences on splits

[github-actions]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.