attribute error handling #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a PV that doesn't have a corresponding device in the lattice
JJL772
reviewed
Nov 14, 2025
Comment on lines
+310
to
+316
| try: | ||
| value = self.virtual_accelerator.get_pvs([reason])[reason] | ||
| except AttributeError as e: | ||
| if reason not in self.omitted: | ||
| self.omitted.append(reason) | ||
| print(f"Error getting param for {reason}: {e}, do not use {reason}") | ||
| return 0 |
Member
There was a problem hiding this comment.
I think this would error out when caget-ing SOMETHING.DRVL. It might be worthwhile to ignore PVs with a .XYZ suffix.
Member
|
I have applied a similar fix to #19, since we've both changed the same code in our PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added error handling to catch the exception raised get searching for a PV that doesn't have a corresponding device in the lattice.
Please review the changes and let me know if you find it problematic in any way.