Actually enable setting slow DAC voltage in human readable format from the client #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruck314
reviewed
Apr 24, 2025
Contributor
Author
|
Tested and confirmed works in hardware |
ruck314
reviewed
Apr 24, 2025
ruck314
approved these changes
Apr 24, 2025
JennySmith888
deleted the
jpsmith/make-slow-dac-voltage-writable-from-client
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error in PR#48 which erroneously included a read argument in the PR set method.
Tested with epix-hr hardware and confirmed it functions as expected.