More tools for dual energy matching #251
Conversation
Using new colocho_feature branch
| YAML_LOCATION = os.path.join(os.path.dirname(__file__), "yaml/") | ||
| print(YAML_LOCATION) |
There was a problem hiding this comment.
What is this print statement trying to accomplish? The only time this print statement will run is when we import the bmad_modeling path, which is not intuitive for the user.
| @@ -45,6 +47,7 @@ def get_energy_gain_pvlist(beam_path): | |||
| except FileNotFoundError: | |||
| print(f"Could not find yaml file {yaml_file_name}") | |||
There was a problem hiding this comment.
I'd like to throw an error here. It can provide more information than the regular FileNotFoundError does. I don't think there's a situation where the caller of this function wants to proceed even if there's a file not found error. If that's the case, the caller can wrap this function in their own try/catch statement.
| @@ -31,6 +32,7 @@ def get_rf_quads_pvlist(tao, all_data_maps, beam_code=1): | |||
| for pv in map.pvlist: | |||
| if "BEAMCODE" in pv: | |||
| pv = map.accelerate_pvname | |||
| pv = pv[0:21] + beam_code + pv[22:] | |||
There was a problem hiding this comment.
Is there a more general way to grab this info? i.e. slit on colon (:) or something else? Or can we always be sure the 0:21 and 22: will be correct?
| @@ -3,10 +3,11 @@ cu: | |||
| L0: REFS:IN20:751:EDES | |||
| L1: REFS:LI21:231:EDES | |||
| L2: REFS:LI24:790:EDES | |||
| L3: REFS:LI30:901:EDES | |||
| L3: REFS:DMP?:400:EDES | |||
|
|
|||
There was a problem hiding this comment.
Does this PV have ? in it? I'm unfamiliar w/ this.
|
@williamColocho any updates on this PR? If it's on hold can we close it for now? |
Creating this for @williamColocho
Adding tools for energy gain in dual energy matching mode. The Dump energy PV needs to be determined dynamically depending on primary/secondary beam path.